From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] virtio: xstats name issue
Date: Mon, 5 Sep 2016 05:35:42 +0000 [thread overview]
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A3EB00306@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <20160905043329.GJ30752@yliu-dev.sh.intel.com>
Hi, Yuanhan:
Thanks for your comments and suggestions.
Zhiyong
> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Monday, September 5, 2016 12:33 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] virtio: xstats name issue
>
> Few generic (trivial) comments first:
>
> - cc to related maintainers
>
> - follow the right prefix, "net/virtio" but not "virtio"
>
> - start commit summary with a verb, and start with "fix" for bug fixing patch.
>
> On Thu, Sep 01, 2016 at 04:01:14PM +0800, Zhiyong Yang wrote:
> > The patch fixes some xstats name issues and make the xstats name
> > conform to code implementation(the function virtio_update_packet_stats).
>
> I would fix it inside virtio_update_packet_stats(), to keep the consistency of
> name style: starts with an even number, and ends with an odd number.
>
> --yliu
next prev parent reply other threads:[~2016-09-05 5:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 8:01 Zhiyong Yang
2016-09-05 4:33 ` Yuanhan Liu
2016-09-05 5:35 ` Yang, Zhiyong [this message]
2016-09-05 6:19 ` Yuanhan Liu
2016-09-06 7:50 ` [dpdk-dev] [PATCH v2] net/virtio: fix " Zhiyong Yang
2016-09-06 12:27 ` Yuanhan Liu
2016-09-07 1:32 ` Yang, Zhiyong
2016-09-07 6:11 ` [dpdk-dev] [PATCH v3] " Zhiyong Yang
2016-09-07 7:22 ` [dpdk-dev] [dpdk-stable] " Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E182254E98A5DA4EB1E657AC7CB9BD2A3EB00306@BGSMSX101.gar.corp.intel.com \
--to=zhiyong.yang@intel.com \
--cc=dev@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).