From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zhiyong.yang@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 2FE799E3
 for <dev@dpdk.org>; Mon,  5 Sep 2016 07:35:47 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga102.jf.intel.com with ESMTP; 04 Sep 2016 22:35:46 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,285,1470726000"; 
   d="scan'208";a="5080949"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
 by orsmga004.jf.intel.com with ESMTP; 04 Sep 2016 22:35:46 -0700
Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Sun, 4 Sep 2016 22:35:45 -0700
Received: from bgsmsx102.gar.corp.intel.com (10.223.4.172) by
 FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Sun, 4 Sep 2016 22:35:45 -0700
Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.37]) by
 BGSMSX102.gar.corp.intel.com ([169.254.2.201]) with mapi id 14.03.0248.002;
 Mon, 5 Sep 2016 11:05:43 +0530
From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] virtio: xstats name issue
Thread-Index: AQHSBCdbpfhOjVdOoU6lPMnIy5UsxaBp+MqAgABq3pA=
Date: Mon, 5 Sep 2016 05:35:42 +0000
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A3EB00306@BGSMSX101.gar.corp.intel.com>
References: <1472716874-34036-1-git-send-email-zhiyong.yang@intel.com>
 <20160905043329.GJ30752@yliu-dev.sh.intel.com>
In-Reply-To: <20160905043329.GJ30752@yliu-dev.sh.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjU2MmFiODktYzJjOC00ZWNmLWI4NzUtMjNiOGQ1MmMxYjNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IllPVkpYMjUzZjZwRitZZ1NxNzhOOHpvZzF2TzFBVnJqeCtwZGtkS2V2N1k9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [10.223.10.10]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] virtio: xstats name issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Sep 2016 05:35:47 -0000

Hi, Yuanhan:

	Thanks for your comments and suggestions.

Zhiyong

> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Monday, September 5, 2016 12:33 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] virtio: xstats name issue
>=20
> Few generic (trivial) comments first:
>=20
> - cc to related maintainers
>=20
> - follow the right prefix, "net/virtio" but not "virtio"
>=20
> - start commit summary with a verb, and start with "fix" for bug fixing p=
atch.
>=20
> On Thu, Sep 01, 2016 at 04:01:14PM +0800, Zhiyong Yang wrote:
> > The patch fixes some xstats name issues and make the xstats name
> > conform to code implementation(the function virtio_update_packet_stats)=
.
>=20
> I would fix it inside virtio_update_packet_stats(), to keep the consisten=
cy of
> name style: starts with an even number, and ends with an odd number.
>=20
> 	--yliu