From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Xie, Huawei" <huawei.xie@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: fix xstats name issue
Date: Wed, 7 Sep 2016 01:32:28 +0000 [thread overview]
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A3EB005D0@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <20160906122743.GD23158@yliu-dev.sh.intel.com>
hi, yuanhan:
Thanks a lot for your clear comments in detail.
Patch v3 will be sent later.
-zhiyong-
> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Tuesday, September 6, 2016 8:28 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>
> Cc: dev@dpdk.org; Xie, Huawei <huawei.xie@intel.com>
> Subject: Re: [PATCH v2] net/virtio: fix xstats name issue
>
> On Tue, Sep 06, 2016 at 03:50:12PM +0800, Zhiyong Yang wrote:
> > The patch fixes some xstats name issues
>
> Please, state **clearly** what the issue is: it's far away from being enough
> just mentioning "fix a issue" without actually telling what it is.
>
> For this case, you could describe the issue like:
>
> We have a stats named "size_1024_1517_packets", while the code
> actually counts the range "[1024, 1518]", which is obviously wrong.
>
> You could even add the related code piece here (you see the context is
> missing in the patch, which is harder for reviewer to see what's actually going
> wrong):
>
> else if (s < 1519)
> stats->size_bins[6]++;
>
> > and make the xstats name conform
> > to the definition of etherStatsPkts1024to1518Octets in rfc2819 page 23.
>
> It's a bit abrupt to metion the RFC here, without some background. It could
> be better if we mention something like: (just followed by above issue
> description).
>
> We could either fix it by correcting the "if" check in the code,
> or fix it by just renaming the stats to conform to the code. The
> later solution is taken because that's what the RFC2819 suggests.
>
>
> > Fixes: 76d4c652e07d ("virtio: add extended stats")
> >
> > ---
>
> Besides that, the three dash "---" means the end of your commit log,
> therefore, it should go --->
>
> >
> > Changes in v2:
> >
> > modify commit summary.
> > add the fixline.
> >
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
>
> ... here
>
> Otherwise, your SoB will be chopped off while apply.
>
> Another thing to note is, it's a good candidate to me for stable branch, thus,
> you may need add following in the commit log before you SoB:
>
> Cc: <stable@dpdk.org>
>
> So, mind to send v3, with above fixes?
>
> Thanks.
>
> --yliu
next prev parent reply other threads:[~2016-09-07 1:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 8:01 [dpdk-dev] [PATCH] virtio: " Zhiyong Yang
2016-09-05 4:33 ` Yuanhan Liu
2016-09-05 5:35 ` Yang, Zhiyong
2016-09-05 6:19 ` Yuanhan Liu
2016-09-06 7:50 ` [dpdk-dev] [PATCH v2] net/virtio: fix " Zhiyong Yang
2016-09-06 12:27 ` Yuanhan Liu
2016-09-07 1:32 ` Yang, Zhiyong [this message]
2016-09-07 6:11 ` [dpdk-dev] [PATCH v3] " Zhiyong Yang
2016-09-07 7:22 ` [dpdk-dev] [dpdk-stable] " Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E182254E98A5DA4EB1E657AC7CB9BD2A3EB005D0@BGSMSX101.gar.corp.intel.com \
--to=zhiyong.yang@intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).