From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 79248DE3 for ; Wed, 21 Sep 2016 07:12:35 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP; 20 Sep 2016 22:12:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,372,1470726000"; d="scan'208";a="12007173" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 20 Sep 2016 22:12:34 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 20 Sep 2016 22:12:33 -0700 Received: from BGSMSX107.gar.corp.intel.com (10.223.4.191) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 20 Sep 2016 22:12:34 -0700 Received: from bgsmsx104.gar.corp.intel.com ([169.254.5.244]) by BGSMSX107.gar.corp.intel.com ([169.254.9.195]) with mapi id 14.03.0248.002; Wed, 21 Sep 2016 10:42:30 +0530 From: "Yang, Zhiyong" To: Yuanhan Liu CC: "dev@dpdk.org" , "thomas.monjalon@6wind.com" , "pmatilai@redhat.com" , "Van Haaren, Harry" Thread-Topic: [PATCH v3 1/2] net/vhost: add a new stats struct Thread-Index: AQHSEyLXNsrxnwtnxEe7cDHbxEneF6CB1XGAgAGQzWA= Date: Wed, 21 Sep 2016 05:12:30 +0000 Message-ID: References: <1473408927-40364-1-git-send-email-zhiyong.yang@intel.com> <1474364205-111569-1-git-send-email-zhiyong.yang@intel.com> <1474364205-111569-2-git-send-email-zhiyong.yang@intel.com> <20160920104427.GS23158@yliu-dev.sh.intel.com> In-Reply-To: <20160920104427.GS23158@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTYzZmMyNmUtZWI2Ni00YWEwLWFjNWQtZTJlYzk3ZWIwZjc2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlBrXC9DYk5sMFpqZXF0Q3BHcnZLRFJ5SzVLOVBkTDJyNGdmdkxkRXpwRDU0PSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/vhost: add a new stats struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2016 05:12:35 -0000 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Tuesday, September 20, 2016 6:44 PM > To: Yang, Zhiyong > Cc: dev@dpdk.org; thomas.monjalon@6wind.com; pmatilai@redhat.com; > Van Haaren, Harry > Subject: Re: [PATCH v3 1/2] net/vhost: add a new stats struct >=20 > On Tue, Sep 20, 2016 at 05:36:44PM +0800, Zhiyong Yang wrote: > > The patch moves all stats counters to a new defined struct vhost_stats > > as follows, in order to manage all stats counters in a unified way and > > simplify the subsequent function > implementation(vhost_dev_xstats_reset). > > > > struct vhost_stats { > > uint64_t rx_pkts; > > uint64_t tx_pkts; >=20 > As I mentioned in last review (you may not notice it though), there is no > need to introduce rx_pkts and tx_pkts: only one of them will be used for = a > specific queue. You could just use "pkts". >=20 >=20 > > uint64_t missed_pkts; > > uint64_t rx_bytes; > > uint64_t tx_bytes; >=20 > Ditto. Ok. You are right. The definition after modification will be : struct vhost_stats { uint64_t pkts; uint64_t bytes; uint64_t missed_pkts; }; >=20 > --yliu