From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4B8F437B3 for ; Wed, 21 Sep 2016 08:15:36 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP; 20 Sep 2016 23:15:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,372,1470726000"; d="scan'208";a="12023070" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 20 Sep 2016 23:15:34 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 20 Sep 2016 23:15:34 -0700 Received: from bgsmsx102.gar.corp.intel.com (10.223.4.172) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 20 Sep 2016 23:15:34 -0700 Received: from bgsmsx104.gar.corp.intel.com ([169.254.5.244]) by BGSMSX102.gar.corp.intel.com ([169.254.2.193]) with mapi id 14.03.0248.002; Wed, 21 Sep 2016 11:45:31 +0530 From: "Yang, Zhiyong" To: Yuanhan Liu CC: "dev@dpdk.org" , "thomas.monjalon@6wind.com" , "pmatilai@redhat.com" , "Van Haaren, Harry" Thread-Topic: [PATCH v3 2/2] net/vhost: add pmd xstats Thread-Index: AQHSEyLY+h9VJVGMbk2KthRefoncgaCB59aAgAGNqgA= Date: Wed, 21 Sep 2016 06:15:30 +0000 Message-ID: References: <1474364205-111569-1-git-send-email-zhiyong.yang@intel.com> <1474364205-111569-3-git-send-email-zhiyong.yang@intel.com> <20160920115017.GV23158@yliu-dev.sh.intel.com> In-Reply-To: <20160920115017.GV23158@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTM0YTgxZmUtNDY1OC00ZjA2LWJkM2UtM2Y4MDljZWU0MmU4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImJCNlhqRVRBaGtia1ZNSTlzWmpHaXZTaXV6NWwwd0k5ZGJkS3FmNzBhRkk9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/vhost: add pmd xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2016 06:15:36 -0000 Hi, yuanhan: > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Tuesday, September 20, 2016 7:50 PM > To: Yang, Zhiyong > Cc: dev@dpdk.org; thomas.monjalon@6wind.com; pmatilai@redhat.com; > Van Haaren, Harry > Subject: Re: [PATCH v3 2/2] net/vhost: add pmd xstats >=20 > On Tue, Sep 20, 2016 at 05:36:45PM +0800, Zhiyong Yang wrote: > > +enum vhost_xstats_pkts { > > + VHOST_UNDERSIZE_PKT =3D 0, > > + VHOST_64_PKT, > > + VHOST_65_TO_127_PKT, > > + VHOST_128_TO_255_PKT, > > + VHOST_256_TO_511_PKT, > > + VHOST_512_TO_1023_PKT, > > + VHOST_1024_TO_1522_PKT, > > + VHOST_1523_TO_MAX_PKT, > > + VHOST_BROADCAST_PKT, > > + VHOST_MULTICAST_PKT, >=20 > Another thing I noted is that you dropped unitcast counting here. I think= the > comment I gave in last email was you don't have to update it every time w= e > rx/tx packets, instead, you could calcuate it on query (at > vhost_dev_xstats_get). I was not asking you to drop it. >=20 Ok, I'm sorry to misunderstand you and will restore it in next V4 patch as you suggest. > --yliu