From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 9F13D2931 for ; Thu, 22 Sep 2016 03:42:27 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 21 Sep 2016 18:42:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,376,1470726000"; d="scan'208";a="1060265841" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 21 Sep 2016 18:42:20 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 21 Sep 2016 18:42:19 -0700 Received: from bgsmsx105.gar.corp.intel.com (10.223.43.197) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 21 Sep 2016 18:42:17 -0700 Received: from bgsmsx104.gar.corp.intel.com ([169.254.5.244]) by BGSMSX105.gar.corp.intel.com ([169.254.3.195]) with mapi id 14.03.0248.002; Thu, 22 Sep 2016 07:12:15 +0530 From: "Yang, Zhiyong" To: Yuanhan Liu CC: "dev@dpdk.org" , "Van Haaren, Harry" , "thomas.monjalon@6wind.com" , "pmatilai@redhat.com" Thread-Topic: [PATCH v4 2/2] net/vhost: add pmd xstats Thread-Index: AQHSE/AZIu6+NK04RESgPTiXPNCtIaCDabiAgAFQkqA= Date: Thu, 22 Sep 2016 01:42:14 +0000 Message-ID: References: <1474364205-111569-2-git-send-email-zhiyong.yang@intel.com> <1474452355-57106-1-git-send-email-zhiyong.yang@intel.com> <1474452355-57106-3-git-send-email-zhiyong.yang@intel.com> <20160921105709.GE23158@yliu-dev.sh.intel.com> In-Reply-To: <20160921105709.GE23158@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWU0MjY5ZGQtMjRkMS00YWMzLTliZTEtOWI3YzM4MjNkMWFlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImlCSEdVR2JVVkZzdWlQR1EyS2ZVZ3BQODJHM0xzZDd4bEU2VG5hd3NnbU09In0= x-ctpclassification: CTP_IC x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/2] net/vhost: add pmd xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2016 01:42:28 -0000 hi, yuanhan: > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Wednesday, September 21, 2016 6:57 PM > To: Yang, Zhiyong > Cc: dev@dpdk.org; Van Haaren, Harry ; > thomas.monjalon@6wind.com; pmatilai@redhat.com > Subject: Re: [PATCH v4 2/2] net/vhost: add pmd xstats >=20 > On Wed, Sep 21, 2016 at 06:05:55PM +0800, Zhiyong Yang wrote: > > +static inline void > > +vhost_count_multicast_broadcast(struct vhost_queue *vq, > > + struct rte_mbuf **bufs, > > + uint16_t count) >=20 > Hmm.. why not just passing "struct rte_mbuf *mbuf"? >=20 Passing "struct rte_mbuf *mbuf" can reduce one parameter. But the function= is small=20 and frequently invoked. So, I define it as the inline function, I think th= e two types of definitions should have the same performance for inline function. Should I modify it in next patch? --zhiyong =20 > --yliu