From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 6EDF1282 for ; Wed, 10 May 2017 12:11:55 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2017 03:11:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,318,1491289200"; d="scan'208";a="259379114" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 10 May 2017 03:11:30 -0700 Received: from bgsmsx153.gar.corp.intel.com (10.224.23.4) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 10 May 2017 03:11:30 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.71]) by BGSMSX153.gar.corp.intel.com ([169.254.2.151]) with mapi id 14.03.0319.002; Wed, 10 May 2017 15:41:28 +0530 From: "Yang, Zhiyong" To: "Mcnamara, John" , "dev@dpdk.org" CC: "yuanhan.liu@linux.intel.com" , "maxime.coquelin@redhat.com" Thread-Topic: [PATCH] doc: update virtio doc Thread-Index: AQHSyVX8P0T5Hp6opkaS+4zHb+9EvaHs+Q0AgABfWQA= Date: Wed, 10 May 2017 10:11:27 +0000 Message-ID: References: <1494397104-56154-1-git-send-email-zhiyong.yang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: update virtio doc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 May 2017 10:11:56 -0000 Hi, John: > -----Original Message----- > From: Mcnamara, John > Sent: Wednesday, May 10, 2017 5:58 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: yuanhan.liu@linux.intel.com; maxime.coquelin@redhat.com > Subject: RE: [PATCH] doc: update virtio doc >=20 >=20 >=20 > > -----Original Message----- > > From: Yang, Zhiyong > > Sent: Wednesday, May 10, 2017 7:18 AM > > To: dev@dpdk.org; Mcnamara, John > > Cc: yuanhan.liu@linux.intel.com; maxime.coquelin@redhat.com; Yang, > > Zhiyong > > Subject: [PATCH] doc: update virtio doc > > > > Add more explanations about vring size changes and virtio_header size. > > > > Signed-off-by: Zhiyong Yang > > --- > > doc/guides/nics/virtio.rst | 13 +++++++++---- > > 1 file changed, 9 insertions(+), 4 deletions(-) > > > > diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst > > index > > 91bedea..36ddd08 100644 > > --- a/doc/guides/nics/virtio.rst > > +++ b/doc/guides/nics/virtio.rst > > @@ -41,8 +41,8 @@ The DPDK extends kni to support vhost raw socket > > interface, which enables vhost to directly read/ write packets > > from/to a physical port. > > With this enhancement, virtio could achieve quite promising performanc= e. > > > > -In future release, we will also make enhancement to vhost backend, - > > releasing peak performance of virtio PMD driver. > > +In future release, we will also make enhancement to vhost backend. > > +Peak performance of virtio PMD driver will be released with every > > +release > > version since DPDK 17.02 release. >=20 > Hi, >=20 > There have been great performance improvements in Virtio in the last few > releases. However, we can't really promise that is will improve in every = release. > I'd suggest removing these two lines and the previous line starting with = "With > this enhancement, virtio could ...". >=20 Ok.=20 >=20 > > > > ... > > > > -* RTE_PKTMBUF_HEADROOM should be defined larger than sizeof(struct > > virtio_net_hdr), which is 10 bytes. > > +* RTE_PKTMBUF_HEADROOM should be defined > > + larger than sizeof(struct virtio_net_hdr), which is 10 bytes, > > +when > > using non-mergeable. > > + larger than sizeof(struct virtio_net_hdr_mrg_rxbuf), which is 12 > > bytes when mergeable or F_VERSION_1 > > + is set. > > >=20 > All constants and struct names should be ```` quoted. Like this: >=20 >=20 > * ``RTE_PKTMBUF_HEADROOM`` should be defined larger than > ``sizeof(struct virtio_net_hdr)``, which is 10 bytes, when using > non-mergeable or larger than ``sizeof(struct virtio_net_hdr_mrg_rxbuf= )``, > which is 12 bytes when mergeable or ``F_VERSION_1`` is set. >=20 Good suggestion. Zhiyong Yang > John >=20