From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 0F72A3253; Wed, 19 Jul 2017 05:23:53 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2017 20:23:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,379,1496127600"; d="scan'208";a="112906855" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 18 Jul 2017 20:23:52 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 18 Jul 2017 20:23:52 -0700 Received: from bgsmsx105.gar.corp.intel.com (10.223.43.197) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 18 Jul 2017 20:23:52 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.22]) by BGSMSX105.gar.corp.intel.com ([169.254.3.174]) with mapi id 14.03.0319.002; Wed, 19 Jul 2017 08:53:49 +0530 From: "Yang, Zhiyong" To: "Hu, Jiayu" , "dev@dpdk.org" CC: "Tan, Jianfeng" , "yliu@fridaylinux.org" , "Yao, Lei A" , "Hu, Jiayu" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/virtio: fix fail to configure rxq interrupt Thread-Index: AQHTAD19uTXBXRMdOkKqVwa282+kPKJaexbw Date: Wed, 19 Jul 2017 03:23:48 +0000 Message-ID: References: <1500434303-12975-1-git-send-email-jiayu.hu@intel.com> In-Reply-To: <1500434303-12975-1-git-send-email-jiayu.hu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWRkODcwYzMtNDU1OC00ZTMwLThlOTgtMDlhYjhjOGM3YzE5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlFiXC9VcmFsZ2JFamcxelZpT1FXY2xuSmxBT2phcHlvTDN5VjVIK1RxTmpBPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix fail to configure rxq interrupt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2017 03:23:54 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jiayu Hu > Sent: Wednesday, July 19, 2017 11:18 AM > To: dev@dpdk.org > Cc: Tan, Jianfeng ; yliu@fridaylinux.org; Yao, Le= i A > ; Hu, Jiayu ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/virtio: fix fail to configure rxq interru= pt >=20 > When use rte_eth_dev_configure() to enable rx queue interrupt for virtio = devices, > virtio_configure_intr() isn't called to set up the interrupt environment,= which > causes rx queue interrupt setup failed. This patch is to fix this issue. >=20 > Fixes: 26b683b4f7d0 ("net/virtio: setup Rx queue interrupts") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jiayu Hu > --- > drivers/net/virtio/virtio_ethdev.c | 7 +++++++ > 1 file changed, 7 insertions(+) Reviewed-by: Zhiyong Yang Thanks Zhiyong > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virt= io_ethdev.c > index 00a3122..66656ed 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1688,6 +1688,13 @@ virtio_dev_configure(struct rte_eth_dev *dev) > return -ENOTSUP; > } >=20 > + if (dev->data->dev_conf.intr_conf.rxq) { > + if (virtio_configure_intr(dev) < 0) { > + PMD_DRV_LOG(ERR, "failed to configure interrupt"); > + return -ENOTSUP; > + } > + } > + > if (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC) > /* Enable vector (0) for Link State Intrerrupt */ > if (VTPCI_OPS(hw)->set_config_irq(hw, 0) =3D=3D > -- > 2.7.4