From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zhiyong.yang@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 7A1DD7CBD
 for <dev@dpdk.org>; Mon,  4 Sep 2017 09:59:57 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 04 Sep 2017 00:59:56 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.41,473,1498546800"; d="scan'208";a="131439818"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
 by orsmga002.jf.intel.com with ESMTP; 04 Sep 2017 00:59:34 -0700
Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Mon, 4 Sep 2017 00:59:34 -0700
Received: from bgsmsx153.gar.corp.intel.com (10.224.23.4) by
 fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Mon, 4 Sep 2017 00:59:34 -0700
Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.62]) by
 BGSMSX153.gar.corp.intel.com ([10.224.23.4]) with mapi id 14.03.0319.002;
 Mon, 4 Sep 2017 13:29:30 +0530
From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: "Yao, Lei A" <lei.a.yao@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "thomas@monjalon.net" <thomas@monjalon.net>, "Yigit, Ferruh"
 <ferruh.yigit@intel.com>, "Wiles, Keith" <keith.wiles@intel.com>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>
Thread-Topic: [dpdk-dev] [PATCH v2 3/4] common_base: extend RTE_MAX_ETHPORTS
 from	32 to 1024
Thread-Index: AQHTJVHiJfsn2VqxlESVHPjzzVa456KkW9wg
Date: Mon, 4 Sep 2017 07:59:29 +0000
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A8AF0D284@BGSMSX101.gar.corp.intel.com>
References: <20170809084203.17562-1-zhiyong.yang@intel.com>
 <20170904055734.21354-1-zhiyong.yang@intel.com>
 <20170904055734.21354-4-zhiyong.yang@intel.com>
 <2DBBFF226F7CF64BAFCA79B681719D953A266703@shsmsx102.ccr.corp.intel.com>
In-Reply-To: <2DBBFF226F7CF64BAFCA79B681719D953A266703@shsmsx102.ccr.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmFhNjcxOTAtYzA4YS00MGMxLTk2YzMtNjM5ZDhiZWNmNjNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjBSdlwvYVhqYjNUNU5KbHg1dWp4b01mbDJGcitLc1pJWUtkQTJnSjJcL3NCRT0ifQ==
x-ctpclassification: CTP_IC
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [10.223.10.10]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 3/4] common_base: extend RTE_MAX_ETHPORTS
 from	32 to 1024
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Sep 2017 07:59:59 -0000

Hi,  Lei:

> -----Original Message-----
> From: Yao, Lei A
> Sent: Monday, September 4, 2017 3:46 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>; dev@dpdk.org
> Cc: thomas@monjalon.net; Yigit, Ferruh <ferruh.yigit@intel.com>; Wiles, K=
eith
> <keith.wiles@intel.com>; stephen@networkplumber.org; Yang, Zhiyong
> <zhiyong.yang@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2 3/4] common_base: extend
> RTE_MAX_ETHPORTS from 32 to 1024
>=20
>=20
>=20
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhiyong Yang
> > Sent: Monday, September 4, 2017 1:58 PM
> > To: dev@dpdk.org
> > Cc: thomas@monjalon.net; Yigit, Ferruh <ferruh.yigit@intel.com>;
> > Wiles, Keith <keith.wiles@intel.com>; stephen@networkplumber.org;
> > Yang, Zhiyong <zhiyong.yang@intel.com>
> > Subject: [dpdk-dev] [PATCH v2 3/4] common_base: extend
> > RTE_MAX_ETHPORTS from 32 to 1024
> >
> > The reasons to modify RTE_MAX_ETHPORTS is the following.
> >
> > 1. RTE_MAX_ETHPORTS=3D32 by default has not met user's requirements wit=
h
> > development of virtualization technology. Some vdev users have to
> > modify the setting before the compiling.
> >
> > 2. port_id have been extended to 16 bits definition. But for many
> > samples such as testpmd, l3fwd, num of port is still limited to
> > RTE_MAX_ETHPORTS=3D32 by default. This may limit usage of 16 bits
> > port_id.
> >
> > So, it is necessary to enlarge RTE_MAX_ETHPORTS to more than 256.
> >
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> > ---
> >  config/common_base | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/config/common_base b/config/common_base index
> > 5e97a08b6..dccc13e31 100644
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -131,7 +131,7 @@ CONFIG_RTE_LIBRTE_KVARGS=3Dy  #
> > CONFIG_RTE_LIBRTE_ETHER=3Dy  CONFIG_RTE_LIBRTE_ETHDEV_DEBUG=3Dn
> > -CONFIG_RTE_MAX_ETHPORTS=3D32
> > +CONFIG_RTE_MAX_ETHPORTS=3D1024
> >  CONFIG_RTE_MAX_QUEUES_PER_PORT=3D1024
> >  CONFIG_RTE_LIBRTE_IEEE1588=3Dn
> >  CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=3D16
> > --
> > 2.13.3
> Hi, Zhiyong
>=20
> I met one issue for changing CONFIG_RTE_MAX_ETHPORTS to 1024.
> One process can only open 1024 file as maximum in common linux distributi=
on,
> after practice, only 1009 socket file can be used for vdev device with te=
stpmd
> sample.

Thanks for your info.  It seems that 1024 is too large and may bring some p=
otential issues.

Thanks
Zhiyong