From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <zhiyong.yang@intel.com> Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3E84029D6 for <dev@dpdk.org>; Tue, 5 Sep 2017 08:51:47 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 23:51:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,478,1498546800"; d="scan'208";a="148169161" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 04 Sep 2017 23:51:47 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 4 Sep 2017 23:51:46 -0700 Received: from bgsmsx102.gar.corp.intel.com (10.223.4.172) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 4 Sep 2017 23:51:46 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.62]) by BGSMSX102.gar.corp.intel.com ([169.254.2.11]) with mapi id 14.03.0319.002; Tue, 5 Sep 2017 12:21:42 +0530 From: "Yang, Zhiyong" <zhiyong.yang@intel.com> To: "Richardson, Bruce" <bruce.richardson@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "thomas@monjalon.net" <thomas@monjalon.net>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Wiles, Keith" <keith.wiles@intel.com>, "stephen@networkplumber.org" <stephen@networkplumber.org> Thread-Topic: [dpdk-dev] [PATCH v2 1/4] ethdev: increase port_id range Thread-Index: AQHTJULrP+ol+InFZ0mLH/Rr6hIbpqKkE5qAgAHHBWA= Date: Tue, 5 Sep 2017 06:51:42 +0000 Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A8AF0DF01@BGSMSX101.gar.corp.intel.com> References: <20170809084203.17562-1-zhiyong.yang@intel.com> <20170904055734.21354-1-zhiyong.yang@intel.com> <20170904055734.21354-2-zhiyong.yang@intel.com> <20170904090658.GA17464@bricha3-MOBL3.ger.corp.intel.com> In-Reply-To: <20170904090658.GA17464@bricha3-MOBL3.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGUyMGJhYjMtYThkOC00N2E5LWJjNmItYmU2ZDIzNjJmZDNlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjR3NXc1eUZcL3hhTUdcL0x1RE9UUTVxUHBrVThHM09vaURVTGUwbXAxV1VJZz0ifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: increase port_id range X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 05 Sep 2017 06:51:48 -0000 Hi, Bruce: Thanks for your comments. Reply inline. Zhiyong > -----Original Message----- > From: Richardson, Bruce > Sent: Monday, September 4, 2017 5:07 PM > To: Yang, Zhiyong <zhiyong.yang@intel.com> > Cc: dev@dpdk.org; thomas@monjalon.net; Yigit, Ferruh > <ferruh.yigit@intel.com>; Wiles, Keith <keith.wiles@intel.com>; > stephen@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: increase port_id range >=20 > On Mon, Sep 04, 2017 at 01:57:31PM +0800, Zhiyong Yang wrote: > > Extend port_id definition from uint8_t to uint16_t in lib and drivers > > data structures, specifically rte_eth_dev_data. Modify the APIs, > > drivers and app using port_id at the same time except some drivers > > such as MLX4 and MLX5 due to fail to compile them in my server. > > > I think you can change those drivers too - it's not hard to set up compil= ation for > MLX drivers (instruction in DPDK docs on the website), and even if you ca= n't > compile test them, e.g. dpaa2 drivers, or other SoC ones, others can do s= o on > your behalf. If you are going to change drivers, I think you should chang= e all of > them across the board. >=20 Ok. I will change them. > > Fix some checkpatch issues from the original code and remove some > > unnecessary cast operations. > > > > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com> > > --- > > app/pdump/main.c | 2 +- > > app/test-eventdev/test_perf_common.h | 6 +- > > app/test-pmd/cmdline.c | 4 +- > > app/test-pmd/config.c | 4 +- > > app/test-pmd/testpmd.c | 18 +- > > app/test-pmd/testpmd.h | 2 +- > > drivers/event/octeontx/ssovf_evdev.c | 6 +- > > drivers/event/octeontx/ssovf_evdev.h | 4 +- > > drivers/event/skeleton/skeleton_eventdev.c | 4 +- > > drivers/event/skeleton/skeleton_eventdev.h | 2 +- > > drivers/event/sw/sw_evdev.c | 4 +- > > drivers/event/sw/sw_evdev.h | 6 +- > > drivers/event/sw/sw_evdev_xstats.c | 8 +- >=20 > These are not ethdev drivers, but eventdev ones. I don't think eventdev n= eeds to > go to 16-bit port numbers, but there is no harm in doing so. > However, it would be best to modify eventdev drivers in a separate patch = - or > even patchset. >=20 I will remove them and focus on ethdev in the patchset. > > drivers/net/af_packet/rte_eth_af_packet.c | 2 +- > > drivers/net/ark/ark_ethdev.c | 2 +- > > drivers/net/ark/ark_udm.h | 2 +- > > drivers/net/avp/avp_ethdev.c | 2 +- > > drivers/net/bnx2x/bnx2x.c | 11 +- > > drivers/net/bnx2x/bnx2x_rxtx.h | 4 +- > > drivers/net/bnx2x/elink.c | 12 +- > > drivers/net/bnx2x/elink.h | 17 +- > > drivers/net/bnxt/bnxt.h | 2 +- > > drivers/net/bnxt/bnxt_ethdev.c | 8 +- > > drivers/net/bnxt/bnxt_rxq.h | 2 +- > > drivers/net/bnxt/bnxt_txq.h | 2 +- > > drivers/net/bnxt/rte_pmd_bnxt.c | 32 +-- > > drivers/net/bnxt/rte_pmd_bnxt.h | 36 ++-- > > drivers/net/bonding/rte_eth_bond.h | 42 ++-- > > drivers/net/bonding/rte_eth_bond_8023ad.c | 6 +- > > drivers/net/bonding/rte_eth_bond_8023ad_private.h | 6 +- > > drivers/net/bonding/rte_eth_bond_api.c | 56 ++--- > > drivers/net/bonding/rte_eth_bond_pmd.c | 30 +-- > > drivers/net/bonding/rte_eth_bond_private.h | 43 ++-- > > drivers/net/e1000/em_rxtx.c | 4 +- > > drivers/net/e1000/igb_rxtx.c | 4 +- > > drivers/net/failsafe/failsafe_ether.c | 4 +- > > drivers/net/failsafe/failsafe_private.h | 4 +- > > drivers/net/fm10k/fm10k.h | 6 +- > > drivers/net/i40e/i40e_ethdev.c | 5 +- > > drivers/net/i40e/i40e_rxtx.h | 4 +- > > drivers/net/i40e/rte_pmd_i40e.c | 50 ++--- > > drivers/net/i40e/rte_pmd_i40e.h | 48 ++--- > > drivers/net/ixgbe/ixgbe_ethdev.c | 5 +- > > drivers/net/ixgbe/ixgbe_rxtx.h | 4 +- > > drivers/net/ixgbe/rte_pmd_ixgbe.c | 60 +++--- > > drivers/net/ixgbe/rte_pmd_ixgbe.h | 70 ++++--- > > drivers/net/nfp/nfp_net.c | 26 +-- > > drivers/net/nfp/nfp_net_pmd.h | 2 +- > > drivers/net/null/rte_eth_null.c | 2 +- > > drivers/net/pcap/rte_eth_pcap.c | 2 +- > > drivers/net/qede/qede_if.h | 2 +- > > drivers/net/ring/rte_eth_ring.c | 2 +- > > drivers/net/vhost/rte_eth_vhost.c | 8 +- > > drivers/net/vhost/rte_eth_vhost.h | 6 +- > > drivers/net/virtio/virtio_pci.h | 2 +- > > drivers/net/virtio/virtio_rxtx.h | 6 +- > > drivers/net/xenvirt/virtqueue.h | 2 +- > > lib/librte_bitratestats/rte_bitrate.c | 2 +- > > lib/librte_bitratestats/rte_bitrate.h | 2 +- > > lib/librte_ether/rte_ethdev.c | 239 +++++++++++---= -------- > > lib/librte_ether/rte_ethdev.h | 238 ++++++++++----= ------- > > lib/librte_ether/rte_tm.c | 62 +++--- > > lib/librte_ether/rte_tm.h | 60 +++--- > > lib/librte_ether/rte_tm_driver.h | 2 +- > > lib/librte_eventdev/rte_eventdev.c | 36 ++-- > > lib/librte_eventdev/rte_eventdev.h | 34 +-- > > lib/librte_eventdev/rte_eventdev_pmd.h | 8 +- >=20 > eventdev changes should be separte patches from ethdev. >=20 Ok. I will remove them from the patchset. Zhiyong > > lib/librte_kni/rte_kni.h | 6 +- > > lib/librte_latencystats/rte_latencystats.c | 12 +- > > lib/librte_pdump/rte_pdump.c | 16 +- > > lib/librte_pdump/rte_pdump.h | 4 +- > > lib/librte_port/rte_port_ethdev.c | 6 +- > > lib/librte_port/rte_port_ethdev.h | 6 +- > > 73 files changed, 733 insertions(+), 715 deletions(-) > >