From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <zhiyong.yang@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
by dpdk.org (Postfix) with ESMTP id AAAC61D90
for <dev@dpdk.org>; Thu, 23 Nov 2017 02:57:21 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
22 Nov 2017 17:57:19 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,438,1505804400";
d="scan'208";a="5400320"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
by orsmga003.jf.intel.com with ESMTP; 22 Nov 2017 17:57:20 -0800
Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by
fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
id 14.3.319.2; Wed, 22 Nov 2017 17:57:19 -0800
Received: from bgsmsx152.gar.corp.intel.com (10.224.48.50) by
FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS)
id 14.3.319.2; Wed, 22 Nov 2017 17:57:19 -0800
Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.245]) by
BGSMSX152.gar.corp.intel.com ([169.254.6.92]) with mapi id 14.03.0319.002;
Thu, 23 Nov 2017 07:27:17 +0530
From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: "Wu, Yanglong" <yanglong.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Wu, Yanglong" <yanglong.wu@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue
Thread-Index: AQHTY/q04QTFElNS2EiJEySE0ddHzaMhM1Pw
Date: Thu, 23 Nov 2017 01:57:16 +0000
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A8B00A870@BGSMSX101.gar.corp.intel.com>
References: <20171123012630.50477-1-yanglong.wu@intel.com>
In-Reply-To: <20171123012630.50477-1-yanglong.wu@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [10.223.10.10]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Nov 2017 01:57:22 -0000
Hi Yanglong,
Good catch! Thanks for your patch.
Thanks
Zhiyong
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu
> Sent: Thursday, November 23, 2017 9:27 AM
> To: dev@dpdk.org
> Cc: Wu, Yanglong <yanglong.wu@intel.com>
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue
>=20
> the port_id was allocated as a inccrete number, for init function was
> passthroughed a wrong size of parameter
The commit log is not clear enough.
>=20
> Fixes:28caa76aea71 ("app/testpmd: fix port id type")
>=20
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> ---
> app/test-pmd/cmdline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> f71d96301..8990ebf6b 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -3352,7 +3352,7 @@ cmdline_parse_token_num_t cmd_vlan_tpid_tpid =3D
> tp_id, UINT16);
> cmdline_parse_token_num_t cmd_vlan_tpid_portid =3D
> TOKEN_NUM_INITIALIZER(struct cmd_vlan_tpid_result,
> - port_id, UINT8);
> + port_id, UINT16);
>=20
> cmdline_parse_inst_t cmd_vlan_tpid =3D {
> .f =3D cmd_vlan_tpid_parsed,
> --
> 2.11.0