From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wu, Yanglong" <yanglong.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue
Date: Thu, 23 Nov 2017 02:05:01 +0000 [thread overview]
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A8B00A89C@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <E182254E98A5DA4EB1E657AC7CB9BD2A8B00A870@BGSMSX101.gar.corp.intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yang, Zhiyong
> Sent: Thursday, November 23, 2017 9:57 AM
> To: Wu, Yanglong <yanglong.wu@intel.com>; dev@dpdk.org
> Cc: Wu, Yanglong <yanglong.wu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue
>
> Hi Yanglong,
>
> Good catch! Thanks for your patch.
>
> Thanks
> Zhiyong
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu
> > Sent: Thursday, November 23, 2017 9:27 AM
> > To: dev@dpdk.org
> > Cc: Wu, Yanglong <yanglong.wu@intel.com>
> > Subject: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue
> >
> > the port_id was allocated as a inccrete number, for init function was
> > passthroughed a wrong size of parameter
>
> The commit log is not clear enough.
>
Except that, you can add
Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com>
> >
> > Fixes:28caa76aea71 ("app/testpmd: fix port id type")
> >
> > Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> > ---
> > app/test-pmd/cmdline.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> > f71d96301..8990ebf6b 100644
> > --- a/app/test-pmd/cmdline.c
> > +++ b/app/test-pmd/cmdline.c
> > @@ -3352,7 +3352,7 @@ cmdline_parse_token_num_t cmd_vlan_tpid_tpid =
> > tp_id, UINT16);
> > cmdline_parse_token_num_t cmd_vlan_tpid_portid =
> > TOKEN_NUM_INITIALIZER(struct cmd_vlan_tpid_result,
> > - port_id, UINT8);
> > + port_id, UINT16);
> >
> > cmdline_parse_inst_t cmd_vlan_tpid = {
> > .f = cmd_vlan_tpid_parsed,
> > --
> > 2.11.0
next prev parent reply other threads:[~2017-11-23 2:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 1:26 Yanglong Wu
2017-11-23 1:57 ` Yang, Zhiyong
2017-11-23 2:05 ` Yang, Zhiyong [this message]
2017-12-22 6:45 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
2017-12-22 7:48 ` Yanglong Wu
2017-12-23 0:04 ` Ferruh Yigit
2018-01-02 5:35 ` [dpdk-dev] [PATCH v3] " Yanglong Wu
2018-01-05 0:58 ` Lu, Wenzhuo
2018-01-09 23:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E182254E98A5DA4EB1E657AC7CB9BD2A8B00A89C@BGSMSX101.gar.corp.intel.com \
--to=zhiyong.yang@intel.com \
--cc=dev@dpdk.org \
--cc=yanglong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).