From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D5EA31E34 for ; Thu, 23 Nov 2017 03:05:08 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Nov 2017 18:05:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,438,1505804400"; d="scan'208";a="176774227" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 22 Nov 2017 18:05:05 -0800 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Nov 2017 18:05:05 -0800 Received: from bgsmsx153.gar.corp.intel.com (10.224.23.4) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Nov 2017 18:05:05 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.245]) by BGSMSX153.gar.corp.intel.com ([169.254.2.240]) with mapi id 14.03.0319.002; Thu, 23 Nov 2017 07:35:02 +0530 From: "Yang, Zhiyong" To: "dev@dpdk.org" CC: "Wu, Yanglong" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue Thread-Index: AQHTY/q04QTFElNS2EiJEySE0ddHzaMhM1PwgAADbmA= Date: Thu, 23 Nov 2017 02:05:01 +0000 Message-ID: References: <20171123012630.50477-1-yanglong.wu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Nov 2017 02:05:09 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yang, Zhiyong > Sent: Thursday, November 23, 2017 9:57 AM > To: Wu, Yanglong ; dev@dpdk.org > Cc: Wu, Yanglong > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue >=20 > Hi Yanglong, >=20 > Good catch! Thanks for your patch. >=20 > Thanks > Zhiyong > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu > > Sent: Thursday, November 23, 2017 9:27 AM > > To: dev@dpdk.org > > Cc: Wu, Yanglong > > Subject: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue > > > > the port_id was allocated as a inccrete number, for init function was > > passthroughed a wrong size of parameter >=20 > The commit log is not clear enough. >=20 Except that, you can add Reviewed-by: Zhiyong Yang > > > > Fixes:28caa76aea71 ("app/testpmd: fix port id type") > > > > Signed-off-by: Yanglong Wu > > --- > > app/test-pmd/cmdline.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > f71d96301..8990ebf6b 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -3352,7 +3352,7 @@ cmdline_parse_token_num_t cmd_vlan_tpid_tpid =3D > > tp_id, UINT16); > > cmdline_parse_token_num_t cmd_vlan_tpid_portid =3D > > TOKEN_NUM_INITIALIZER(struct cmd_vlan_tpid_result, > > - port_id, UINT8); > > + port_id, UINT16); > > > > cmdline_parse_inst_t cmd_vlan_tpid =3D { > > .f =3D cmd_vlan_tpid_parsed, > > -- > > 2.11.0