From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 451F9160; Sat, 30 Dec 2017 15:19:41 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Dec 2017 06:19:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,480,1508828400"; d="scan'208";a="19985993" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 30 Dec 2017 06:19:40 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 30 Dec 2017 06:19:40 -0800 Received: from BGSMSX107.gar.corp.intel.com (10.223.4.191) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 30 Dec 2017 06:19:40 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.245]) by BGSMSX107.gar.corp.intel.com ([169.254.9.78]) with mapi id 14.03.0319.002; Sat, 30 Dec 2017 19:49:37 +0530 From: "Yang, Zhiyong" To: Thomas Monjalon CC: "dev@dpdk.org" , "Yigit, Ferruh" , "stable@dpdk.org" Thread-Topic: [PATCH v2] bus/pci: fix wrong intr_handle.type with uio_pci_generic Thread-Index: AQHTgHpsBXdhyAxWxkCsI7O9d0f53KNZzS0AgAIj2pA= Date: Sat, 30 Dec 2017 14:19:36 +0000 Message-ID: References: <20171228061210.64767-1-zhiyong.yang@intel.com> <20171229075511.33180-1-zhiyong.yang@intel.com> <2110508.9oViqIghhz@xps> In-Reply-To: <2110508.9oViqIghhz@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] bus/pci: fix wrong intr_handle.type with uio_pci_generic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Dec 2017 14:19:43 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, December 29, 2017 7:07 PM > To: Yang, Zhiyong > Cc: dev@dpdk.org; Yigit, Ferruh ; stable@dpdk.org > Subject: Re: [PATCH v2] bus/pci: fix wrong intr_handle.type with uio_pci_= generic >=20 > 29/12/2017 08:55, Zhiyong Yang: > > For virtio legacy device, testpmd startup fails when using > > uio_pci_generic. The issue is caused by invoking the function > > pci_ioport_map. The right intr_handle.type is already set before > > calling it, we should avoid overwriting the default value "RTE_ > > INTR_HANDLE_UNKNOWN" in it. Besides, the removal has no harm to other > > cases since it already is set to this value (0) at init. >=20 > To be more precise, it is set to 0 by a memset on the whole struct during > allocation in the scan function (pci_scan_one). Ok >=20 > > --- a/drivers/bus/pci/linux/pci.c > > +++ b/drivers/bus/pci/linux/pci.c > > @@ -723,7 +723,6 @@ pci_ioport_map(struct rte_pci_device *dev, int bar > __rte_unused, > > if (!found) > > return -1; > > > > - dev->intr_handle.type =3D RTE_INTR_HANDLE_UNKNOWN; >=20 > There is the same assignment in pci_vfio_map_resource_primary(), > pci_vfio_map_resource_secondary() and pci_uio_map_resource(). >=20 > Please could you check why there is such assignments? Well, Let me check them later. Thanks Zhiyong