From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: Yuanhan Liu <yliu@fridaylinux.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/vhost: fix extend MAX_QUEUES to resolve startup failure
Date: Wed, 10 Jan 2018 01:26:46 +0000 [thread overview]
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A8B021F02@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <20180109132347.GL29540@yliu-mob>
Yuanhan,
> -----Original Message-----
> From: Yuanhan Liu [mailto:yliu@fridaylinux.org]
> Sent: Tuesday, January 9, 2018 9:24 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] examples/vhost: fix extend MAX_QUEUES
> to resolve startup failure
>
> On Thu, Jan 04, 2018 at 02:33:32PM +0800, Zhiyong Yang wrote:
> > When binding X710 NIC (i40e driver) to DPDK, vhost sample startups
> > failure.
> > The sample requires that MAX_QUEUES should be defined no less than 320.
> > So, the patch redefines MAX_QUEUES 320 to fix the issue.
>
> It just makes the issue disappear. It doesn't really fix the issue.
> And I belive we have tried to fix this kind of issues in this way many times.
> (just check the git history). As you known, none of them really worked. You
> just added one more try, which is very likely will be broken again when Intel
> has one more new NIC.
>
> The error comes from:
>
> if (dev_info.max_rx_queues > MAX_QUEUES) {
> rte_exit(EXIT_FAILURE,
> "please define MAX_QUEUES no less than %u in %s\n",
> dev_info.max_rx_queues, __FILE__);
> }
>
> I think such check is overkill and we don't really need that. Could you just
> remove such check and do some validations on few difference nics?
>
Agreed, Such check doesn't help anything, Let me send V2 to remove it if nothing can be affected.
Thanks
Zhiyong
> Thanks.
>
> --yliu
next prev parent reply other threads:[~2018-01-10 1:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 6:33 Zhiyong Yang
2018-01-09 13:23 ` Yuanhan Liu
2018-01-10 1:26 ` Yang, Zhiyong [this message]
2018-01-10 6:01 ` [dpdk-dev] [PATCH v2] examples/vhost: fix remove dev_info.max_rx_queues checking to solve " Zhiyong Yang
2018-01-10 12:36 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E182254E98A5DA4EB1E657AC7CB9BD2A8B021F02@BGSMSX101.gar.corp.intel.com \
--to=zhiyong.yang@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).