From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id A21671B2DD for ; Fri, 19 Jan 2018 11:01:15 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jan 2018 02:01:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,381,1511856000"; d="scan'208";a="21014083" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 19 Jan 2018 02:01:13 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 19 Jan 2018 02:01:13 -0800 Received: from BGSMSX107.gar.corp.intel.com (10.223.4.191) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 19 Jan 2018 02:01:13 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.245]) by BGSMSX107.gar.corp.intel.com ([169.254.9.78]) with mapi id 14.03.0319.002; Fri, 19 Jan 2018 15:31:10 +0530 From: "Yang, Zhiyong" To: Thomas Monjalon CC: "dev@dpdk.org" , "Yigit, Ferruh" , "olivier.matz@6wind.com" Thread-Topic: [PATCH] lib/librte_mbuf: remove void * pointer cast Thread-Index: AQHTkQWxxD9DKKtxREqWnrMruAt2lqN6lCGAgABhzsA= Date: Fri, 19 Jan 2018 10:01:09 +0000 Message-ID: References: <20180119091240.25085-1-zhiyong.yang@intel.com> <22300087.hk3FSSTWuc@xps> In-Reply-To: <22300087.hk3FSSTWuc@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] lib/librte_mbuf: remove void * pointer cast X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 10:01:16 -0000 Thank you, Thomas, I will do that according to your comments. Thanks Zhiyong > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, January 19, 2018 5:38 PM > To: Yang, Zhiyong > Cc: dev@dpdk.org; Yigit, Ferruh ; > olivier.matz@6wind.com > Subject: Re: [PATCH] lib/librte_mbuf: remove void * pointer cast >=20 > Hi Zhiyong, >=20 > 3 comments about patch formatting: >=20 > 1/ the title must follow the convention seen in the git history. > If you use git log --oneline lib/librte_mbuf you will see that it must st= art with > "mbuf:" >=20 > 2/ The * character does not play well when patch saved in a file, and it = is > useless: "void pointer" is correct for understanding. >=20 > 3/ You must Cc the maintainer as described in MAINTAINERS. > You can use devtools/get-maintainer.sh. > Here, I Cc Olivier. >=20 > Thanks >=20 >=20 > 19/01/2018 10:12, Zhiyong Yang: > > It is unnecessary to cast from void * to struct rte_mbuf *, the change > > can make code more simple. > > > > Signed-off-by: Zhiyong Yang