From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 1A21F397D for ; Fri, 30 Mar 2018 09:32:38 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Mar 2018 00:32:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,380,1517904000"; d="scan'208";a="216050956" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 30 Mar 2018 00:32:38 -0700 Received: from bgsmsx153.gar.corp.intel.com (10.224.23.4) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 30 Mar 2018 00:32:37 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.233]) by BGSMSX153.gar.corp.intel.com ([169.254.2.232]) with mapi id 14.03.0319.002; Fri, 30 Mar 2018 13:02:35 +0530 From: "Yang, Zhiyong" To: "Chen, Junjie J" , "Tan, Jianfeng" , "maxime.coquelin@redhat.com" , "mtetsuyah@gmail.com" CC: "dev@dpdk.org" , "Chen, Junjie J" , "Chen@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] net/vhost: fix segfault when creating vdev dynamically Thread-Index: AQHTx/S0FoQBDlbLDEynoyQUDSABkKPoX9CQ Date: Fri, 30 Mar 2018 07:32:34 +0000 Message-ID: References: <20180329153544.270488-1-junjie.j.chen@intel.com> <20180330065831.107558-1-junjie.j.chen@intel.com> In-Reply-To: <20180330065831.107558-1-junjie.j.chen@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/vhost: fix segfault when creating vdev dynamically X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 07:32:39 -0000 Hi Maxime, Junjie, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Junjie Chen > Sent: Friday, March 30, 2018 2:59 PM > To: Tan, Jianfeng ; maxime.coquelin@redhat.com; > mtetsuyah@gmail.com > Cc: dev@dpdk.org; Chen, Junjie J ; > Chen@dpdk.org > Subject: [dpdk-dev] [PATCH v3] net/vhost: fix segfault when creating vdev > dynamically >=20 > When creating vdev dynamically, vhost pmd driver starts directly without > checking TX/RX queues are ready or not, and thus causes segmentation faul= t > when vhost library accesses queues. This patch adds a flag to check wheth= er > queues are setup or not, and adds queues setup into dev_start function to > allow user to start them after setting up. >=20 > Fixes: aed0b12930b3 ("net/vhost: fix socket file deleted on stop") > Signed-off-by: Chen, Junjie > --- Thanks for Junjie's patch! I also came across the similar issue when developing virtio-user server mod= e. >>From user's perspective, the patch can fix the issue in my user case instea= d of=20 the patch http://www.dpdk.org/dev/patchwork/patch/36340/ Tested-by: Zhiyong Yang Thanks Zhiyong