From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <zhiyong.yang@intel.com> Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 6B5EA28F3; Wed, 23 May 2018 13:37:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 May 2018 04:37:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,432,1520924400"; d="scan'208";a="44101245" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga006.jf.intel.com with ESMTP; 23 May 2018 04:37:12 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 23 May 2018 04:37:12 -0700 Received: from bgsmsx105.gar.corp.intel.com (10.223.43.197) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 23 May 2018 04:37:12 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.244]) by BGSMSX105.gar.corp.intel.com ([169.254.3.165]) with mapi id 14.03.0319.002; Wed, 23 May 2018 17:07:11 +0530 From: "Yang, Zhiyong" <zhiyong.yang@intel.com> To: "Yang, Zhiyong" <zhiyong.yang@intel.com>, Thomas Monjalon <thomas@monjalon.net>, "Yigit, Ferruh" <ferruh.yigit@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@mellanox.com>, "Iremonger, Bernard" <bernard.iremonger@intel.com>, "Yao, Lei A" <lei.a.yao@intel.com>, "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>, "Bie, Tiwei" <tiwei.bie@intel.com>, "stable@dpdk.org" <stable@dpdk.org>, "Van Haaren, Harry" <harry.van.haaren@intel.com> Thread-Topic: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs Thread-Index: AQHT7sVdX7BUqRGnxES6+eTFOwB8OKQ2vxKAgALreICAAF48gIAAAcgAgAFYxACAAFsuAIAAE4GAgAC+41CAAKXEQA== Date: Wed, 23 May 2018 11:37:10 +0000 Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A8B0D796F@BGSMSX101.gar.corp.intel.com> References: <20180518095937.28710-1-zhiyong.yang@intel.com> <9489790.cv73CZovxU@xps> <45bf17fa-fb43-7917-8cf6-63864f9d2c4c@intel.com> <3059388.qb94XYSleL@xps> <E182254E98A5DA4EB1E657AC7CB9BD2A8B0D739B@BGSMSX101.gar.corp.intel.com> In-Reply-To: <E182254E98A5DA4EB1E657AC7CB9BD2A8B0D739B@BGSMSX101.gar.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 23 May 2018 11:37:16 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yang, Zhiyong > Sent: Wednesday, May 23, 2018 9:52 AM > To: Thomas Monjalon <thomas@monjalon.net>; Yigit, Ferruh > <ferruh.yigit@intel.com> > Cc: dev@dpdk.org; Matan Azrad <matan@mellanox.com>; Iremonger, Bernard > <bernard.iremonger@intel.com>; Yao, Lei A <lei.a.yao@intel.com>; > maxime.coquelin@redhat.com; Bie, Tiwei <tiwei.bie@intel.com>; > stable@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com> > Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit functio= n for > vdevs >=20 > Hi Thomas, >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Wednesday, May 23, 2018 3:49 AM > > To: Yigit, Ferruh <ferruh.yigit@intel.com> > > Cc: Yang, Zhiyong <zhiyong.yang@intel.com>; dev@dpdk.org; Matan Azrad > > <matan@mellanox.com>; Iremonger, Bernard > > <bernard.iremonger@intel.com>; Yao, Lei A <lei.a.yao@intel.com>; > > maxime.coquelin@redhat.com; Bie, Tiwei <tiwei.bie@intel.com>; > > stable@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com> > > Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit > > function for vdevs > > > > 22/05/2018 20:38, Ferruh Yigit: > > > On 5/22/2018 2:12 PM, Thomas Monjalon wrote: > > > > Any update to improve this workaround? > > > > > > > > 21/05/2018 18:38, Thomas Monjalon: > > > >> 21/05/2018 18:32, Ferruh Yigit: > > > >>> On 5/21/2018 11:54 AM, Thomas Monjalon wrote: > > > >>>> 19/05/2018 16:19, Thomas Monjalon: > > > >>>>> 18/05/2018 18:29, Ferruh Yigit: > > > >>>>>> On 5/18/2018 4:55 PM, Matan Azrad wrote: > > > >>>>>>> Hi all > > > >>>>>>> > > > >>>>>>> While this patch also applied I don't understand it. > > > >>>>>>> Is it mandatory for each PMD to free all its resources in > dev_close()? > > > >>>>>>> Or it should be done by the rte_device remove function? > > > >>>>>>> > > > >>>>>>> If the resource cleanup should be done by the remove > > > >>>>>>> function I think it should be called for all the devices (pci= , vdev, > etc). > > > >>>>>>> > > > >>>>>>> Is there an exit function for EAL to clean rte_eal_init()? > > > >>>>>>> If no, looks > > like we need it... > > > >>>>>> > > > >>>>>> Hi Matan, > > > >>>>>> > > > >>>>>> I believe there is a gap in resource cleanup. > > > >>>>>> dev_close() it not for resource cleanup, it should be in PMD > > > >>>>>> remove() functions, and PMDs have it. The problem is remove > > > >>>>>> path is > > not called in application exit. > > > >>>>>> > > > >>>>>> As far as I know there is no simple API to clean the > > > >>>>>> resources, having it may help application to do the cleanup. > > > >>>>>> > > > >>>>>> I have seen the rte_eal_cleanup() API by Harry, that can be > > > >>>>>> extended to cover PMD resource cleanup if there is enough > > motivation for it. > > > >>>>> > > > >>>>> Yes, EAL resources should be removed by the function > > rte_eal_cleanup(). > > > >>>>> And ethdev ports must be removed by rte_eth_dev_close(). > > > >>>> > > > >>>> This patch is relying on rte_eth_dev_detach() to remove the EAL > device. > > > >>>> It should be done in rte_eal_cleanup(). > > > >>>> > > > >>>> I am concerned that this patch is workarounding a miss in > > > >>>> rte_eal_cleanup, and takes a different action only for vdev. It > > > >>>> is a bad > > example. > > > >>> > > > >>> Indeed it does workaround, but it is needed to fix a defect in vi= rtio-user. > > > >> > > > >> The defect is still in virtio-user after this patch. > > > >> To make this workaround acceptable, you need: > > > >> 1/ add the virtio-user known issue in release notes >=20 > I don't think it is a bug for virtio-user. Just no proper implemented API= can free > the virtio-user resources allocated by probe method. > Socket file is just one example, other resources are freed in the remove > method. Testpmd was always missing the functionality. >=20 > > > >> 2/ add a FIXME comment in testpmd code explaining the workaround > > > >> 3/ commit to work on rte_eal_cleanup() in 18.08 Do you mean to work on rte_eal_cleanup() for all drivers or for virtio user= only? > > > > > > I have submitted following patch [1], can it cover 2/ for the v18.05-= rc5? > > > > > > [1] > > > https://dpdk.org/dev/patchwork/patch/40350/ > > > > Yes, it covers item 2/. Thanks > > > > >=20 > rte_eal_cleanup() is a proper API, which is needed to clean up resources= . >=20 > Thanks > Zhiyong