From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 786AA6910 for ; Thu, 2 Jun 2016 04:08:59 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 01 Jun 2016 19:08:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,404,1459839600"; d="xls'32?scan'32,208,32";a="967120863" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 01 Jun 2016 19:08:58 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 1 Jun 2016 19:08:56 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 1 Jun 2016 19:08:55 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.150]) by shsmsx102.ccr.corp.intel.com ([169.254.2.220]) with mapi id 14.03.0248.002; Thu, 2 Jun 2016 10:08:53 +0800 From: "Gu, YongjieX" To: "Zhang, Helin" , "dev@dpdk.org" CC: "Zhang, Helin" Thread-Topic: [dpdk-dev] [PATCH v2 01/15] i40e/base: remove HMC AQ APIs Thread-Index: AQHRtYTVeFMXALOwUUqFOS6GCokKzZ/VeI+Q Date: Thu, 2 Jun 2016 02:08:53 +0000 Message-ID: References: <1462438424-22574-1-git-send-email-helin.zhang@intel.com> <1464070989-32726-1-git-send-email-helin.zhang@intel.com> <1464070989-32726-2-git-send-email-helin.zhang@intel.com> In-Reply-To: <1464070989-32726-2-git-send-email-helin.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 01/15] i40e/base: remove HMC AQ APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jun 2016 02:09:00 -0000 Tested-by: Yongjie Gu - Check patch: success - Apply patch: success - compilation: success OS: fedora20 GCC: gcc_x86-64, 4.8.3 ICC: 16.0.2 Commit: 587d684d70f9d7f74e77a886c58103b40409caea i686-native-linuxapp-icc: compile pass x86_64-native-linuxapp-gcc-combined: compile pass i686-native-linuxapp-gcc: compile pass x86_64-native-linuxapp-gcc: compile pass x86_64-native-linuxapp-icc: compile pass x86_64-native-linuxapp-gcc-debug: compile pass x86_64-native-linuxapp-gcc-shared: compile pass x86_64-native-linuxapp-clang: compile pass - dts validation:=20 -- Test Commit: c8c33ad7f94c59d1c0676af0cfd61207b3e808db -- OS/Kernel: Fedora22/4.2.8-200.fc22.x86_64 -- GCC: gcc version 5.1.1 -- CPU: Intel(R) Xeon(R) CPU E5-2658 v2 @ 2.40GHz -- NIC: Intel Corporation Ethernet Controller XL710 for 40GbE QSFP+ [8086:= 1584] -- total 106,failed 10(Detailed case list see in the attachment,10 failed = cases also exist in daily regression test) Thanks Yongjie -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Helin Zhang Sent: Tuesday, May 24, 2016 2:23 PM To: dev@dpdk.org Cc: Zhang, Helin Subject: [dpdk-dev] [PATCH v2 01/15] i40e/base: remove HMC AQ APIs HMC AQ APIs were removed from the latest datasheet, and hence remove its im= plementations and relevant. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_adminq.c | 4 --- drivers/net/i40e/base/i40e_adminq_cmd.h | 25 -------------- drivers/net/i40e/base/i40e_common.c | 61 -----------------------------= ---- drivers/net/i40e/base/i40e_prototype.h | 8 ----- 4 files changed, 98 deletions(-) diff --git a/drivers/net/i40e/base/i40e_adminq.c b/drivers/net/i40e/base/i4= 0e_adminq.c index 222add4..0e4198e 100644 --- a/drivers/net/i40e/base/i40e_adminq.c +++ b/drivers/net/i40e/base/i40e_adminq.c @@ -683,10 +683,6 @@ enum i40e_status_code i40e_init_adminq(struct i40e_hw = *hw) hw->aq.nvm_release_on_done =3D false; hw->nvmupd_state =3D I40E_NVMUPD_STATE_INIT; =20 - ret_code =3D i40e_aq_set_hmc_resource_profile(hw, - I40E_HMC_PROFILE_DEFAULT, - 0, - NULL); #endif /* PF_DRIVER */ ret_code =3D I40E_SUCCESS; =20 diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/bas= e/i40e_adminq_cmd.h index fe9d5b5..58ba609 100644 --- a/drivers/net/i40e/base/i40e_adminq_cmd.h +++ b/drivers/net/i40e/base/i40e_adminq_cmd.h @@ -224,10 +224,6 @@ enum i40e_admin_queue_opc { i40e_aqc_opc_resume_port_tx =3D 0x041C, i40e_aqc_opc_configure_partition_bw =3D 0x041D, =20 - /* hmc */ - i40e_aqc_opc_query_hmc_resource_profile =3D 0x0500, - i40e_aqc_opc_set_hmc_resource_profile =3D 0x0501, - /* phy commands*/ i40e_aqc_opc_get_phy_abilities =3D 0x0600, i40e_aqc_opc_set_phy_config =3D 0x0601, @@ -1646,27 +1642,6 @@ struct i40e_aqc_configure_partition_bw_data { =20 I40E_CHECK_STRUCT_LEN(0x22, i40e_aqc_configure_partition_bw_data); =20 -/* Get and set the active HMC resource profile and status. - * (direct 0x0500) and (direct 0x0501) - */ -struct i40e_aq_get_set_hmc_resource_profile { - u8 pm_profile; - u8 pe_vf_enabled; - u8 reserved[14]; -}; - -I40E_CHECK_CMD_LENGTH(i40e_aq_get_set_hmc_resource_profile); - -enum i40e_aq_hmc_profile { - /* I40E_HMC_PROFILE_NO_CHANGE =3D 0, reserved */ - I40E_HMC_PROFILE_DEFAULT =3D 1, - I40E_HMC_PROFILE_FAVOR_VF =3D 2, - I40E_HMC_PROFILE_EQUAL =3D 3, -}; - -#define I40E_AQ_GET_HMC_RESOURCE_PROFILE_PM_MASK 0xF -#define I40E_AQ_GET_HMC_RESOURCE_PROFILE_COUNT_MASK 0x3F - /* Get PHY Abilities (indirect 0x0600) uses the generic indirect struct */ =20 /* set in param0 for get phy abilities to report qualified modules */ diff= --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_c= ommon.c index ef3425e..7a5f754 100644 --- a/drivers/net/i40e/base/i40e_common.c +++ b/drivers/net/i40e/base/i40e_common.c @@ -3240,67 +3240,6 @@ enum i40e_status_code i40e_aq_debug_write_register(s= truct i40e_hw *hw, } =20 /** - * i40e_aq_get_hmc_resource_profile - * @hw: pointer to the hw struct - * @profile: type of profile the HMC is to be set as - * @pe_vf_enabled_count: the number of PE enabled VFs the system has - * @cmd_details: pointer to command details structure or NULL - * - * query the HMC profile of the device. - **/ -enum i40e_status_code i40e_aq_get_hmc_resource_profile(struct i40e_hw *hw, - enum i40e_aq_hmc_profile *profile, - u8 *pe_vf_enabled_count, - struct i40e_asq_cmd_details *cmd_details) -{ - struct i40e_aq_desc desc; - struct i40e_aq_get_set_hmc_resource_profile *resp =3D - (struct i40e_aq_get_set_hmc_resource_profile *)&desc.params.raw; - enum i40e_status_code status; - - i40e_fill_default_direct_cmd_desc(&desc, - i40e_aqc_opc_query_hmc_resource_profile); - status =3D i40e_asq_send_command(hw, &desc, NULL, 0, cmd_details); - - *profile =3D (enum i40e_aq_hmc_profile)(resp->pm_profile & - I40E_AQ_GET_HMC_RESOURCE_PROFILE_PM_MASK); - *pe_vf_enabled_count =3D resp->pe_vf_enabled & - I40E_AQ_GET_HMC_RESOURCE_PROFILE_COUNT_MASK; - - return status; -} - -/** - * i40e_aq_set_hmc_resource_profile - * @hw: pointer to the hw struct - * @profile: type of profile the HMC is to be set as - * @pe_vf_enabled_count: the number of PE enabled VFs the system has - * @cmd_details: pointer to command details structure or NULL - * - * set the HMC profile of the device. - **/ -enum i40e_status_code i40e_aq_set_hmc_resource_profile(struct i40e_hw *hw, - enum i40e_aq_hmc_profile profile, - u8 pe_vf_enabled_count, - struct i40e_asq_cmd_details *cmd_details) -{ - struct i40e_aq_desc desc; - struct i40e_aq_get_set_hmc_resource_profile *cmd =3D - (struct i40e_aq_get_set_hmc_resource_profile *)&desc.params.raw; - enum i40e_status_code status; - - i40e_fill_default_direct_cmd_desc(&desc, - i40e_aqc_opc_set_hmc_resource_profile); - - cmd->pm_profile =3D (u8)profile; - cmd->pe_vf_enabled =3D pe_vf_enabled_count; - - status =3D i40e_asq_send_command(hw, &desc, NULL, 0, cmd_details); - - return status; -} - -/** * i40e_aq_request_resource * @hw: pointer to the hw struct * @resource: resource id diff --git a/drivers/net/i40e/base/i40e_prototype.h b/drivers/net/i40e/base= /i40e_prototype.h index 674430d..3b57683 100644 --- a/drivers/net/i40e/base/i40e_prototype.h +++ b/drivers/net/i40e/base/i40e_prototype.h @@ -345,10 +345,6 @@ enum i40e_status_code i40e_aq_config_vsi_bw_limit(stru= ct i40e_hw *hw, enum i40e_status_code i40e_aq_dcb_ignore_pfc(struct i40e_h= w *hw, u8 tcmap, bool request, u8 *tcmap_ret, struct i40e_asq_cmd_details *cmd_details); -enum i40e_status_code i40e= _aq_get_hmc_resource_profile(struct i40e_hw *hw, - enum i40e_aq_hmc_profile *profile, - u8 *pe_vf_enabled_count, - struct i40e_asq_cmd_details *cmd_details); enum i40e_status_code i40e_aq_config_switch_comp_ets_bw_limit( struct i40e_hw *hw, u16 seid, struct i40e_aqc_configure_switching_comp_ets_bw_limit_data *bw_data, @@ -= 359,10 +355,6 @@ enum i40e_status_code i40e_aq_config_vsi_ets_sla_bw_limit(= struct i40e_hw *hw, struct i40e_asq_cmd_details *cmd_details); enum i40e_status_code i40e_= aq_dcb_updated(struct i40e_hw *hw, struct i40e_asq_cmd_details *cmd_details); -enum i40e_status_code i40e= _aq_set_hmc_resource_profile(struct i40e_hw *hw, - enum i40e_aq_hmc_profile profile, - u8 pe_vf_enabled_count, - struct i40e_asq_cmd_details *cmd_details); enum i40e_status_code i40e_aq_config_switch_comp_bw_limit(struct i40e_hw *= hw, u16 seid, u16 credit, u8 max_bw, struct i40e_asq_cmd_details *cmd_details); -- 2.5.0