From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 122FC42C01; Thu, 1 Jun 2023 10:15:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C6F9406BA; Thu, 1 Jun 2023 10:15:33 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4DE8E406B3 for ; Thu, 1 Jun 2023 10:15:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685607330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N0Txzyv+mcIaYdlvdVXR8C+nr3jL8su7JqZbwsbxGtc=; b=WXdj+1rqH0UshZv91qFR6rSOLmNU4PI7y9QA7JoVmVy7RaoEl3F55tGGoO7UiRSOu6hbhk kuNHMWYNx1rmSRZktNPVxGxWDpC0dZd/KyIf9LNhKiJnKzqoeUwSrQvaHjykZKui4518Uo iccu4rYQgBUk8NMj7pq7mAJXHaQySWU= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-600-esKiiQ2-MDCnNz4KWGgb7Q-1; Thu, 01 Jun 2023 04:15:21 -0400 X-MC-Unique: esKiiQ2-MDCnNz4KWGgb7Q-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-513f337d478so426202a12.3 for ; Thu, 01 Jun 2023 01:15:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685607320; x=1688199320; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AbIIIziVv1tsIHceU2J/hE40oIhUS2m2Apha5zdwbBc=; b=RZqY5FMMl9Bnu5KT7R9JJydsw5B8hRgp9kBlb5+nBJO70GnyDwr5Cj/N5OlVytPXEQ ZPEIjOend6xiJ//hnmGuIieJlgC2G9zS0NEk2tDYMzgLiwjXg/pdEm65WWsHXpUyJS0X OaHrkrlS+PGZUgxBLkgya/1BiYr5cnY5aVERpsldc/faVv3mq6tDwZ7nKrL4t0M+HJTs SkSVK2naja0zhkrjqviroWuZ+p+EMK0AIW4LGRWqvFL125OC4WPdnxgZt+qQblAFsniN nu/KDGYAMKBvh+IUOR/iJue4vI6h/lY9XLal6Bo8ZbsxkWJGwVxduTOJsXyZ1FQevRSP IfIw== X-Gm-Message-State: AC+VfDy1zR+v7zlwFJllFhG6HPmx8dN/noZqnfHYrPlUEc/K8YC1TC9L o4EwELFYnYp2W8vgds5LOlj6L4QExyTf+kmqxJnp5fYtZAAT0H1verXpFCQCKaJ1HCJI9Pi3Hqt 5Y8A= X-Received: by 2002:a17:906:da8b:b0:96f:d345:d0f7 with SMTP id xh11-20020a170906da8b00b0096fd345d0f7mr7667985ejb.62.1685607320514; Thu, 01 Jun 2023 01:15:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7yGRiijBREsy2dkf7I7oF8oU/2d2WKiPXbmK0bYqJfE3hqE6ptSedJrId5NDICj/qWRr2xng== X-Received: by 2002:a17:906:da8b:b0:96f:d345:d0f7 with SMTP id xh11-20020a170906da8b00b0096fd345d0f7mr7667966ejb.62.1685607320187; Thu, 01 Jun 2023 01:15:20 -0700 (PDT) Received: from [10.39.192.59] (5920ab7b.static.cust.trined.nl. [89.32.171.123]) by smtp.gmail.com with ESMTPSA id s2-20020aa7cb02000000b005105f002fd1sm6893976edt.66.2023.06.01.01.15.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Jun 2023 01:15:19 -0700 (PDT) From: Eelco Chaudron To: "Xia, Chenbo" Cc: Maxime Coquelin , Thomas Monjalon , david.marchand@redhat.com, dev@dpdk.org Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick Date: Thu, 01 Jun 2023 10:15:18 +0200 X-Mailer: MailMate (1.14r5964) Message-ID: In-Reply-To: References: <168431450017.558450.16680518469610688737.stgit@ebuild.local> <168431455219.558450.14986601389394385835.stgit@ebuild.local> <49ec9930-66b8-fc95-72ad-5cb012ed8635@redhat.com> <16690234.Ash8RoxBsO@thomas> <7f1be920-0318-ae7f-4c2e-cc08b2083f7c@redhat.com> <11c40eca-5847-dfb4-470d-7da86fe7e51e@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1 Jun 2023, at 4:18, Xia, Chenbo wrote: >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Wednesday, May 31, 2023 5:29 PM >> To: Xia, Chenbo ; Thomas Monjalon >> ; Eelco Chaudron ; >> david.marchand@redhat.com >> Cc: dev@dpdk.org >> Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interrup= t >> kick >> >> >> >> On 5/31/23 08:19, Xia, Chenbo wrote: >>>> -----Original Message----- >>>> From: Maxime Coquelin >>>> Sent: Tuesday, May 30, 2023 11:17 PM >>>> To: Thomas Monjalon ; Eelco Chaudron >>>> ; Xia, Chenbo ; >>>> david.marchand@redhat.com >>>> Cc: dev@dpdk.org >>>> Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the >> interrupt >>>> kick >>>> >>>> >>>> >>>> On 5/30/23 15:16, Thomas Monjalon wrote: >>>>> 30/05/2023 15:02, Maxime Coquelin: >>>>>> >>>>>> On 5/17/23 11:09, Eelco Chaudron wrote: >>>>>>> This patch adds an operation callback which gets called every time >> the >>>>>>> library wants to call eventfd_write(). This eventfd_write() call >> could >>>>>>> result in a system call, which could potentially block the PMD >> thread. >>>>>>> >>>>>>> The callback function can decide whether it's ok to handle the >>>>>>> eventfd_write() now or have the newly introduced function, >>>>>>> rte_vhost_notify_guest(), called at a later time. >>>>>>> >>>>>>> This can be used by 3rd party applications, like OVS, to avoid >> system >>>>>>> calls being called as part of the PMD threads. >>>>>>> >>>>>>> Signed-off-by: Eelco Chaudron >>>>>>> --- >>>>>>> lib/vhost/meson.build | 2 ++ >>>>>>> lib/vhost/rte_vhost.h | 23 +++++++++++++++++- >>>>>>> lib/vhost/socket.c | 63 >>>> ++++++++++++++++++++++++++++++++++++++++++++++--- >>>>>>> lib/vhost/version.map | 9 +++++++ >>>>>>> lib/vhost/vhost.c | 38 ++++++++++++++++++++++++++++++ >>>>>>> lib/vhost/vhost.h | 58 ++++++++++++++++++++++++++++++++--= - >> --- >>>> ------- >>>>>>> 6 files changed, 171 insertions(+), 22 deletions(-) >>>>>>> >>>>>> >>>>>> >>>>>> The patch looks good to me, but that's the first time we use functio= n >>>>>> versioning in Vhost library, so I'd like another pair of eyes to be >>>> sure >>>>>> I don't miss anything. >>>>>> >>>>>> Reviewed-by: Maxime Coquelin >>>>>> >>>>>> Thomas, do we need to mention it somewhere in the release note? >>>>> >>>>> If compatibility is kept, I think we don't need to mention it. >>>>> >>>>> >>>> >>>> Thanks Thomas for the information. >>>> >>>> Maxime >>> >>> About release note, except the versioning, there is also one new API >> introduced >>> in this patch, so we still need to mention this in release note >> >> Right, good catch. >> Eelco, let me know what you would put, I'll add it while applying (No >> need for a new revision). > > Btw, the vhost_lib.rst also needs a new item.. What about the following? diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vh= ost_lib.rst index e8bb8c9b7b..0f964d7a4a 100644 --- a/doc/guides/prog_guide/vhost_lib.rst +++ b/doc/guides/prog_guide/vhost_lib.rst @@ -334,6 +334,11 @@ The following is an overview of some key Vhost API fun= ctions: Clean DMA vChannel finished to use. After this function is called, the specified DMA vChannel should no longer be used by the Vhost library= . +* ``rte_vhost_notify_guest(int vid, uint16_t queue_id)`` + + Inject the offloaded interrupt received by the 'guest_notify' callback, + into the vhost device's queue. + Vhost-user Implementations -------------------------- Maxime do you want to add it, or do you want a new rev? > Thanks, > Chenbo > >> >> Thanks, >> Maxime >> >>> Thanks, >>> Chenbo