From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 12BAF25D9 for ; Tue, 11 Dec 2018 03:28:13 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Dec 2018 18:28:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,340,1539673200"; d="scan'208";a="302746936" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 10 Dec 2018 18:28:12 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 10 Dec 2018 18:28:12 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.201]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.176]) with mapi id 14.03.0415.000; Tue, 11 Dec 2018 10:28:10 +0800 From: "Wang, Haiyue" To: "Zhang, Qi Z" , "Yan, Zhirun" , "dev@dpdk.org" Thread-Topic: [PATCH v1] net/i40e: remove redundant code in free queues. Thread-Index: AQHUkEzlexMkoLu1W02f3akRFAq6w6V3YzgAgACGv1D//5L5gIAArzSQgAAM2ACAAI0BEA== Date: Tue, 11 Dec 2018 02:28:09 +0000 Message-ID: References: <20181210133205.70401-1-zhirun.yan@intel.com> <039ED4275CED7440929022BC67E70611532FC030@SHSMSX103.ccr.corp.intel.com> <039ED4275CED7440929022BC67E70611532FC0A6@SHSMSX103.ccr.corp.intel.com> <039ED4275CED7440929022BC67E70611532FC61C@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E70611532FC61C@SHSMSX103.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTEzZTQxMzgtNTA2Yy00NGQ5LTg4ZjAtZGNkOTVhMGU1YThkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK2l5Wk1JZkpXM0g1Q0ZiVTdxSnZGb2dCXC8rSk11TDlGTmwybFFoUWtYZXpSeEY5ZWNcL1B3dXhlc1kwajY4M3lJIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] net/i40e: remove redundant code in free queues. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2018 02:28:14 -0000 > -----Original Message----- > From: Zhang, Qi Z > Sent: Tuesday, December 11, 2018 09:22 > To: Wang, Haiyue ; Yan, Zhirun > ; dev@dpdk.org > Subject: RE: [PATCH v1] net/i40e: remove redundant code in free queues. >=20 >=20 >=20 > > -----Original Message----- > > From: Wang, Haiyue > > Sent: Tuesday, December 11, 2018 1:00 AM > > To: Zhang, Qi Z ; Yan, Zhirun > > ; dev@dpdk.org > > Subject: RE: [PATCH v1] net/i40e: remove redundant code in free queues. > > > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Monday, December 10, 2018 22:08 > > > To: Wang, Haiyue ; Yan, Zhirun > > > ; dev@dpdk.org > > > Subject: RE: [PATCH v1] net/i40e: remove redundant code in free queue= s. > > > > > > > > > > > > > -----Original Message----- > > > > From: Wang, Haiyue > > > > Sent: Monday, December 10, 2018 8:47 PM > > > > To: Zhang, Qi Z ; Yan, Zhirun > > > > ; dev@dpdk.org > > > > Subject: RE: [PATCH v1] net/i40e: remove redundant code in free que= ues. > > > > > > > > > -----Original Message----- > > > > > From: Zhang, Qi Z > > > > > Sent: Monday, December 10, 2018 20:36 > > > > > To: Yan, Zhirun ; dev@dpdk.org; Wang, > > > > > Haiyue > > > > > Subject: RE: [PATCH v1] net/i40e: remove redundant code in free q= ueues. > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Yan, Zhirun > > > > > > Sent: Monday, December 10, 2018 9:32 PM > > > > > > To: dev@dpdk.org; Zhang, Qi Z ; Wang, > > > > > > Haiyue > > > > > > Cc: Yan, Zhirun > > > > > > Subject: [PATCH v1] net/i40e: remove redundant code in free que= ues. > > > > > > > > > > > > Before this patch, there are two functions that will clear > > > > > > RX/TX queues > > > > > > number: rte_eth_dev_close() and i40e_dev_free_queues(). > > > > > > > > > > I agree with what the patch changed, but the commit log is not > > > > comprehensive. > > > > > I40e_dev_free_queues is not only in the path of > > > > > rte_eth_dev_close but also rte_eth_dev_reset. > > > > > So > > > > > For rte_eth_dev_close, its redundant because of duplication. > > > > > For rte_eth_dev_reset its redundant because of not necessary, > > > > > since following dev_configure is required after dev_reset and it > > > > > will be updated > > > > correctly. > > > > > > > > > > > > > How about this commit message ? > > > > > > > > net/i40e: queue management data set is out of the API scope. > > > > > > > > Function i40e_dev_free_queues is used to free specific i40e queue > > > > entries, but should not be used to set the upper level queue > > > > management data in 'struct rte_eth_dev_data', such as ' > > > > nb_rx/tx_queues ', which are maintained by > > 'rte_eth_dev_rx/tx_queue_config'. > > > > > > Ideally it should be what you described , but if you look at exist > > > code in different PMD nb_rx/tx_queues is modified anywhere. > > > so I'm not very sure if nb_rx/tx_queues should only be modified in > > > rte_ethdev_rx/tx_queue_config is the original design, and I don't > > > have confidence those cleanup is always correct, that's why I will > > > prefer an explanation that prove this code clean is correct. I think > > > your comment is much fit for a patch set that do all the cleanup. > > > > > I searched the " dev->data->nb_rx_queues =3D 0 ", 10 PMDs drivers write > > like this, and these functions nearly look like the same, like *copy*. > > :) >=20 > that's not all the case, if you just search "nb_rx_queues =3D " you will = get more > cases that nb_rx_queues is modified by PMD directly. > We should make sure all of them can be cleanup with that way before have = our > statement, but this is beyond this patch's scope. >=20 I studied again, yes! I took two PMDs (pcap, ring) to understand more: drivers/net/pcap/rte_eth_pcap.c:961: data->nb_rx_queues =3D (uint16_t)nb= _rx_queues; drivers/net/ring/rte_eth_ring.c:319: data->nb_rx_queues =3D (uint16_t)nb= _rx_queues; I found that they used internal queue management data, such as : struct pmd= _internals --> struct ring_queue rx_ring_queues[RTE_PMD_RING_MAX_RX_RINGS]; then the eth_o= ps API rx/tx_queue_release have empty functions, like: static void eth_queue_release(void *q __rte_unused) { ; } It seems that the queue data management design is flexible, just let the P= MD handles them carefully, and matches the rte_eth_xxx API's behavior. > > > > Well, from the feature ' VIRTCHNL_OP_REQUEST_QUEUES ', it will cause > > the VF PMD internally reset after the application like testpmd calls th= e ' > > rte_eth_dev_configure ' API. > > The internal reset has to free the internal resource firstly, which > > will call free functions such as ' i40e_dev_free_queues ', if this > > function reset the upper level parameters like nb_rx/tx_queues from ' > > rte_eth_dev_configure ', then this standard API will be changed to be m= ore > ugly, like: >=20 > Yes, that's why I also recommend Zhirun to merge this change to the patch= for > VIRTCHNL_OP_REQUEST_QUEUES as another option. > But as an independent patch, I think current comments should be OK, becau= se > the context here is we have no idea about VIRTCHNL_OP_REQUEST_QUEUES > yet. >=20 > Again, the words in your comment > ".... but should not be used to set the upper level queue management data= in > 'struct rte_eth_dev_data', such as 'nb_rx/tx_queues ', which are maintain= ed by > 'rte_eth_dev_rx/tx_queue_config" > I think it is a good design, but I'm not sure if this is considered at or= iginal > because it is broken everywhere with current implementations. >=20 > So from my view, you are introducing a new design and should be covered i= n a > separate patch set which focus on it, but this is not current patch's pur= pose. >=20 >=20 > > > > ' rte_eth_dev_configure ' > > --> diag =3D (*dev->dev_ops->dev_configure)(dev); > > the PMD's dev_configure needs to be changed the new return > > value, such as 1 to > > tell the ' rte_eth_dev_configure ' reconfigures the > > nb_rx/tx_queues again, such as > > diag =3D (*dev->dev_ops->dev_configure)(dev); > > if (diag =3D=3D 1) { > > rte_eth_dev_rx_queue_config(dev, nb_rx_q); > > rte_eth_dev_tx_queue_config(dev, nb_tx_q); > > } else if (diag !=3D 0) { > > RTE_PMD_DEBUG_TRACE("port%d dev_configure =3D %d\n", > > port_id, diag); > > rte_eth_dev_rx_queue_config(dev, 0); > > rte_eth_dev_tx_queue_config(dev, 0); > > return eth_err(port_id, diag); > > } > > This makes VIRTCHNL_OP_REQUEST_QUEUES work, but patch will be 100% > > rejected. > > Finally, we found that it we made i40e a good PMD boy, then all will be= happy. > > This is the long history. > > > > And if ' nb_rx/tx_queues ' stands for the number of TX/RX queues array > > entries, we'd better make code looks clean, like an OOP programming: > > let the rte_eth_xxx API handle its data. > > > > struct rte_eth_dev_data { > > char name[RTE_ETH_NAME_MAX_LEN]; /**< Unique identifier name */ > > > > void **rx_queues; /**< Array of pointers to RX queues. */ > > void **tx_queues; /**< Array of pointers to TX queues. */ > > uint16_t nb_rx_queues; /**< Number of RX queues. */ > > uint16_t nb_tx_queues; /**< Number of TX queues. */ > > > > And the API 'void rte_eth_dev_close(uint16_t port_id)' will make things= clean: > > > > /* old behaviour: only free queue arrays */ > > dev->data->nb_rx_queues =3D 0; > > rte_free(dev->data->rx_queues); > > dev->data->rx_queues =3D NULL; > > dev->data->nb_tx_queues =3D 0; > > rte_free(dev->data->tx_queues); > > dev->data->tx_queues =3D NULL; > > > > > > > > > > > > > > > > > > This patch remove redundant code in i40e_dev_free_queues(). > > > > > > > > > > > > Signed-off-by: Zhirun Yan > > > > > > Signed-off-by: Haiyue Wang > > > > > > --- > > > > > > drivers/net/i40e/i40e_rxtx.c | 2 -- > > > > > > 1 file changed, 2 deletions(-) > > > > > > > > > > > > diff --git a/drivers/net/i40e/i40e_rxtx.c > > > > > > b/drivers/net/i40e/i40e_rxtx.c index > > > > > > e1152ff0e..cc953ad58 100644 > > > > > > --- a/drivers/net/i40e/i40e_rxtx.c > > > > > > +++ b/drivers/net/i40e/i40e_rxtx.c > > > > > > @@ -2753,7 +2753,6 @@ i40e_dev_free_queues(struct rte_eth_dev > > *dev) > > > > > > i40e_dev_rx_queue_release(dev->data->rx_queues[i]); > > > > > > dev->data->rx_queues[i] =3D NULL; > > > > > > } > > > > > > - dev->data->nb_rx_queues =3D 0; > > > > > > > > > > > > for (i =3D 0; i < dev->data->nb_tx_queues; i++) { > > > > > > if (!dev->data->tx_queues[i]) @@ -2761,7 +2760,6 @@ > > > > > > i40e_dev_free_queues(struct rte_eth_dev *dev) > > > > > > i40e_dev_tx_queue_release(dev->data->tx_queues[i]); > > > > > > dev->data->tx_queues[i] =3D NULL; > > > > > > } > > > > > > - dev->data->nb_tx_queues =3D 0; > > > > > > } > > > > > > > > > > > > #define I40E_FDIR_NUM_TX_DESC I40E_MIN_RING_DESC > > > > > > -- > > > > > > 2.17.1