Re: [dpdk-dev] [PATCH v1] net/ice: avoid the parsed devargs value being overwritten

["Wang, Haiyue" <haiyue.wang@intel.com>]

> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Monday, October 14, 2019 16:25
> To: Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1] net/ice: avoid the parsed devargs value being overwritten
> 
> On 10/09, Haiyue Wang wrote:
> >If the default dev args 'proto_xtr' is not in the first position, it
> >will overwrite the parsed queue map value, so use an new variable to
> >save the default.
> >
> >And enhance the error message printing to show the right information.
> >
> >Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> >---
> > drivers/net/ice/ice_ethdev.c | 44 +++++++++++++++++++++++++-----------
> > drivers/net/ice/ice_ethdev.h |  1 +
> > 2 files changed, 32 insertions(+), 13 deletions(-)
> >
> 
> [snip]
> 
> >@@ -2126,6 +2142,8 @@ ice_dev_close(struct rte_eth_dev *dev)
> > 	rte_free(hw->port_info);
> > 	hw->port_info = NULL;
> > 	ice_shutdown_all_ctrlq(hw);
> >+	rte_free(pf->proto_xtr);
> >+	pf->proto_xtr = NULL;
> 
> These two lines seems irrelevant to this patch, I noticed that the resource
> free operation was contained in the original patch, and they are removed
> unexpectedly by commit bd513ece3c40 ("net/ice: release port upon close"),
> sorry for not catching it when reviewing.
> 
> Prefer one individual patch for the fix.
> 

Planed to send two patches, but a little lazy. :) Will do this in v2.

> Thanks,
> Xiaolong
> 
> >
> > 	dev->dev_ops = NULL;
> > 	dev->rx_pkt_burst = NULL;
> >diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h
> >index 182c6f611..2fd98817b 100644
> >--- a/drivers/net/ice/ice_ethdev.h
> >+++ b/drivers/net/ice/ice_ethdev.h
> >@@ -288,6 +288,7 @@ struct ice_pf {
> >  */
> > struct ice_devargs {
> > 	int safe_mode_support;
> >+	uint8_t proto_xtr_dflt;
> > 	uint8_t proto_xtr[ICE_MAX_QUEUE_NUM];
> > };
> >
> >--
> >2.17.1
> >