From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: Jerin Jacob <jerinjacobk@gmail.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dpdk-dev <dev@dpdk.org>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>,
"Kinsella, Ray" <ray.kinsella@intel.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>,
"Sun, Chenmin" <chenmin.sun@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
"Slava Ovsiienko" <viacheslavo@mellanox.com>,
Stephen Hemminger <stephen@networkplumber.org>,
David Marchand <david.marchand@redhat.com>,
Jerin Jacob <jerinj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information
Date: Wed, 30 Oct 2019 04:43:23 +0000 [thread overview]
Message-ID: <E3B9F2FDCB65864C82CD632F23D8AB8773D8C836@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <CALBAE1O8PgWqHAsH+eTCy8+WCzmpgCv2vd13y6k-zgjPA9VpJA@mail.gmail.com>
> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Wednesday, October 30, 2019 12:38
> To: Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: Thomas Monjalon <thomas@monjalon.net>; Wang, Haiyue <haiyue.wang@intel.com>; dpdk-dev
> <dev@dpdk.org>; Ye, Xiaolong <xiaolong.ye@intel.com>; Kinsella, Ray <ray.kinsella@intel.com>;
> Iremonger, Bernard <bernard.iremonger@intel.com>; Sun, Chenmin <chenmin.sun@intel.com>; Andrew
> Rybchenko <arybchenko@solarflare.com>; Slava Ovsiienko <viacheslavo@mellanox.com>; Stephen Hemminger
> <stephen@networkplumber.org>; David Marchand <david.marchand@redhat.com>; Jerin Jacob
> <jerinj@marvell.com>
> Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information
>
> On Tue, Oct 29, 2019 at 10:29 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >
> > On 10/26/2019 7:58 AM, Jerin Jacob wrote:
> > > On Sat, Oct 26, 2019 at 3:57 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > >>
> > >> 25/10/2019 18:02, Jerin Jacob:
> > >>> On Fri, Oct 25, 2019 at 9:15 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > >>>> 25/10/2019 16:08, Ferruh Yigit:
> > >>>>> On 10/25/2019 10:36 AM, Thomas Monjalon wrote:
> > >>>>>> 15/10/2019 09:51, Haiyue Wang:
> > >>>>>>> Some PMDs have more than one RX/TX burst paths, add the ethdev API
> > >>>>>>> that allows an application to retrieve the mode information about
> > >>>>>>> Rx/Tx packet burst such as Scalar or Vector, and Vector technology
> > >>>>>>> like AVX2.
> > >>>>>>
> > >>>>>> I missed this patch. I and Andrew, maintainers of ethdev, were not CC'ed.
> > >>>>>> Ferruh, I would expect to be Cc'ed and/or get a notification before merging.
> > >>>>>
> > >>>>> It has been discussed in the mail list and went through multiple discussions,
> > >>>>> patch is out since the August, +1 to cc all maintainers I missed that part,
> > >>>>> but when the patch is reviewed and there is no objection, why block the merge?
> > >>>>
> > >>>> I'm not saying blocking the merge.
> > >>>> My bad is that I missed the patch and I am asking for help with a notification
> > >>>> in this case. Same for Andrew I guess.
> > >>>> Note: it is merged in master and I am looking to improve this feature.
> > >>>
> > >>>>>>> +/**
> > >>>>>>> + * Ethernet device RX/TX queue packet burst mode information structure.
> > >>>>>>> + * Used to retrieve information about packet burst mode setting.
> > >>>>>>> + */
> > >>>>>>> +struct rte_eth_burst_mode {
> > >>>>>>> + uint64_t options;
> > >>>>>>> +};
> > >>>>>>
> > >>>>>> Why a struct for an integer?
> > >>>>>
> > >>>>> Again by a request from me, to not need to break the API if we need to add more
> > >>>>> thing in the future.
> > >>>>
> > >>>> I would replace it with a string. This is the most flexible API.
> > >>>
> > >>> IMO, Probably, best of both worlds make a good option here,
> > >>> as Haiyue suggested if we have an additional dev_specific[1] in structure.
> > >>> and when a pass to the application, let common code make final string as
> > >>> (options flags to string + dev_specific)
> > >>>
> > >>> options flag can be zero if PMD does not have any generic flags nor
> > >>> interested in such a scheme.
> > >>> Generic flags will help at least to have some common code.
> > >>>
> > >>> [1]
> > >>> struct rte_eth_burst_mode {
> > >>> uint64_t options;
> > >>> char dev_specific[128]; /* PMD has specific burst mode information */
> > >>> };
> > >>
> > >> I really don't see how we can have generic flags.
> > >> The flags which are proposed are just matching
> > >> the functions implemented in Intel PMDs.
> > >> And this is a complicate solution.
> > >> Why not just returning a name for the selected Rx/Tx mode?
> > >
> > > +1 only for the name
> > >
> > > Let me clarify my earlier proposal:
> > >
> > > 1) The public ethdev API should return only "string" i.e the flags
> > > SHOULD NOT be exposed as ethdev API
> > > i.e
> > > int rte_eth_tx_burst_mode_name(uint16_t port_id, uint16_t queue_id, char *name);
> > >
> > > 2) The PMD interface to the common code can be following
> > >
> > > struct eth_pmd_burst_mode {
> > > uint64_t options;
> > > char name[128]; /* PMD specific burst mode information */
> > > };
> > >
> > > typedef int (*eth_burst_mode_get_t)(struct rte_eth_dev *dev,
> > > uint16_t queue_id, struct eth_burst_mode *mode)
> > >
> > > 3) The implementation of rte_eth_tx_burst_mode_name() shall do optons
> > > flag to string converion(again internal to common code implemetation)
> > > and concatenate with eth_pmd_burst_mode::name
> > >
> > > This would help to reuse some of the flags to name conversion logic
> > > across all PMDs.
> > > And PMD are free to return eth_pmd_burst_mode::options as zero in
> > > that case final
> > > string only be eth_pmd_burst_mode::name.
> > >
> > > I don't see any downside with this approach and it best of both worlds.
> > >
> >
> > I agree it will be hard or restrictive if we want to represent the all data path
> > options with standardized data.
> >
> > But the free text string is good for logging, but not good if the application
> > will get this input and give some decision with it.
>
> I was thinking it is only for logging. But if the application needs to have
> some decisions with it then below scheme is the best way,
>
> Though I am not sure, allowing such decision in the application is good or not.
> For instance, If vectorization is AVX512, What kind of decision an
> application can make? If it can make some decision then, will work for
> the NEON case?
>
>
> >
> > To combine both two, what do you think a mixed approach, similar to what Jerin
> > described but both options and string is visible to application,
> > and make 'options' only for vectorization information which is limited and be
> > standardized:
> >
> > int rte_eth_tx_burst_mode_get(uint16_t port_id, uint16_t queue_id,
> > struct rte_eth_burst_mode *mode);
> >
> > struct rte_eth_burst_mode {
> > uint64_t options; // This is only for VECTORIZATION mode
> > char *alternate_options;
> > }
> >
> > since "burst_mode:options" only for vectorization, it is limited and can be easy
> > to consume by applications.
> > This means removing some data path options, like "BULK_ALLOC" from current struct.
>
> ACK
>
> >
> > 'rte_eth_burst_mode_option_name()' can get "struct rte_eth_burst_mode" as
> > parameter and convert the 'options' to string and combine into single string as
> > a helper function to the applications.
> >
> > And +1 to providing NULL "alternate_options" can return the size of that string.
>
> ACK
>
> >
> > And as we find more common/standard data path options, we can move them to the
> > bitfield and remove from the free text. Does it make sense?
>
> Yes, if, we need to give provide a method to take action for
> application else not.
>
The new member "char *alternate_options;" is assigned by PMD as static string ?
Like: mode->alternate_options = "abcd" ? Or with fixed array size, so PMD can
format it as needed ?
> >
next prev parent reply other threads:[~2019-10-30 4:43 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 7:51 [dpdk-dev] [PATCH v4 0/4] get Rx/Tx packet " Haiyue Wang
2019-10-15 7:51 ` [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting " Haiyue Wang
2019-10-15 10:45 ` Ferruh Yigit
2019-10-15 11:23 ` Wang, Haiyue
2019-10-15 11:13 ` Ferruh Yigit
2019-10-25 9:36 ` Thomas Monjalon
2019-10-25 10:26 ` Jerin Jacob
2019-10-25 13:59 ` Wang, Haiyue
2019-10-25 14:08 ` Ferruh Yigit
2019-10-25 15:45 ` Thomas Monjalon
2019-10-25 16:02 ` Jerin Jacob
2019-10-25 22:27 ` Thomas Monjalon
2019-10-26 4:40 ` Wang, Haiyue
2019-10-26 6:24 ` Thomas Monjalon
2019-10-26 9:23 ` Wang, Haiyue
2019-10-26 16:23 ` Thomas Monjalon
2019-10-29 14:27 ` Ferruh Yigit
2019-11-03 20:35 ` Ray Kinsella
2019-11-03 22:41 ` Thomas Monjalon
2019-11-04 9:49 ` Ray Kinsella
2019-11-04 9:54 ` Thomas Monjalon
2019-11-04 10:03 ` Ray Kinsella
2019-11-04 10:46 ` Wang, Haiyue
2019-11-04 11:30 ` Thomas Monjalon
2019-11-04 12:07 ` Ray Kinsella
2019-11-04 13:09 ` Thomas Monjalon
2019-11-04 13:48 ` Ray Kinsella
2019-11-04 14:17 ` Wang, Haiyue
2019-10-26 6:40 ` Slava Ovsiienko
2019-10-26 9:31 ` Wang, Haiyue
2019-10-26 6:58 ` Jerin Jacob
2019-10-26 9:37 ` Wang, Haiyue
2019-10-29 3:37 ` Jerin Jacob
2019-10-29 4:44 ` Wang, Haiyue
2019-10-29 5:19 ` Jerin Jacob
2019-10-29 5:42 ` Wang, Haiyue
2019-10-29 5:47 ` Jerin Jacob
2019-10-29 5:56 ` Wang, Haiyue
2019-10-29 6:00 ` Wang, Haiyue
2019-10-29 8:34 ` Jerin Jacob
2019-10-29 11:26 ` Wang, Haiyue
2019-10-29 12:56 ` Jerin Jacob
2019-10-29 13:51 ` Wang, Haiyue
2019-10-29 14:08 ` Jerin Jacob
2019-10-29 15:42 ` Wang, Haiyue
2019-10-29 15:59 ` Jerin Jacob
2019-10-29 16:16 ` Wang, Haiyue
2019-10-29 16:59 ` Ferruh Yigit
2019-10-30 4:38 ` Jerin Jacob
2019-10-30 4:43 ` Wang, Haiyue [this message]
2019-10-30 8:14 ` Wang, Haiyue
2019-10-31 10:46 ` Jerin Jacob
2019-10-31 11:15 ` Ray Kinsella
2019-10-31 11:16 ` Wang, Haiyue
2019-10-31 14:58 ` Ferruh Yigit
2019-10-31 15:07 ` Wang, Haiyue
2019-10-31 15:29 ` Ferruh Yigit
2019-10-31 15:54 ` Wang, Haiyue
2019-10-31 11:09 ` Ray Kinsella
2019-10-15 7:51 ` [dpdk-dev] [PATCH v4 2/4] net/i40e: add Rx/Tx burst mode get callbacks Haiyue Wang
2019-10-15 7:51 ` [dpdk-dev] [PATCH v4 3/4] net/ice: " Haiyue Wang
2019-10-15 7:51 ` [dpdk-dev] [PATCH v4 4/4] app/testpmd: show the Rx/Tx burst mode description Haiyue Wang
2019-10-15 12:11 ` [dpdk-dev] [PATCH v4 0/4] get Rx/Tx packet burst mode information Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E3B9F2FDCB65864C82CD632F23D8AB8773D8C836@shsmsx102.ccr.corp.intel.com \
--to=haiyue.wang@intel.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=chenmin.sun@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=ray.kinsella@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@mellanox.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).