From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50191A04A2; Wed, 6 Nov 2019 02:40:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0E8831BFDF; Wed, 6 Nov 2019 02:40:30 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id A48531BFCD for ; Wed, 6 Nov 2019 02:40:28 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2019 17:40:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,272,1569308400"; d="scan'208";a="192302354" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 05 Nov 2019 17:40:26 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 Nov 2019 17:40:25 -0800 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 Nov 2019 17:40:25 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.108]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.215]) with mapi id 14.03.0439.000; Wed, 6 Nov 2019 09:40:23 +0800 From: "Wang, Haiyue" To: 'Thomas Monjalon' CC: "'dev@dpdk.org'" , "'jerinjacobk@gmail.com'" , "Yigit, Ferruh" , "'arybchenko@solarflare.com'" , "'viacheslavo@mellanox.com'" , "'damarion@cisco.com'" , "Ye, Xiaolong" , "Sun, Chenmin" , "Kinsella, Ray" , "Liu, Yu Y" Thread-Topic: [dpdk-dev] [PATCH v2] ethdev: enhance the API for getting burst mode information Thread-Index: AQHVkv0KxvY/V6FXTUaxieDROzbUpad8x5cAgACMNeCAAAt4UA== Date: Wed, 6 Nov 2019 01:40:22 +0000 Message-ID: References: <20191104103920.64907-1-haiyue.wang@intel.com> <2399300.Xf6G4o05WB@xps> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2YzNzRmMGEtNzc0Mi00ZGE1LWJkY2UtZDU5YjE5YTgxYWY0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicFhPTGVLQlhWZVJUU1JIb3pKZHlEUUp5dlRTaWV0NU9wRmgrMmpvd295YVpuVjdZd3BjSVwvNFk0TnRBdUk1dUYifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] ethdev: enhance the API for getting burst mode information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, Haiyue > Sent: Wednesday, November 6, 2019 09:22 > To: Thomas Monjalon > Cc: dev@dpdk.org; jerinjacobk@gmail.com; Yigit, Ferruh ; > arybchenko@solarflare.com; viacheslavo@mellanox.com; damarion@cisco.com; = Ye, Xiaolong > ; Sun, Chenmin ; Kinsella, = Ray ; > Liu, Yu Y > Subject: RE: [dpdk-dev] [PATCH v2] ethdev: enhance the API for getting bu= rst mode information >=20 > Hi Thomas, >=20 > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Wednesday, November 6, 2019 08:34 > > To: Wang, Haiyue > > Cc: dev@dpdk.org; jerinjacobk@gmail.com; Yigit, Ferruh ; > > arybchenko@solarflare.com; viacheslavo@mellanox.com; damarion@cisco.com= ; Ye, Xiaolong > > ; Sun, Chenmin ; Kinsella= , Ray > ; > > Liu, Yu Y > > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: enhance the API for getting = burst mode information > > > > 04/11/2019 11:39, Haiyue Wang: > > > Change the type of burst mode information from bit field to free stri= ng > > > data, so that each PMD can describe the Rx/Tx busrt functions flexibl= y. > > > > > > Signed-off-by: Haiyue Wang > > > --- > > > > > > v2: - Drop the bit field for burst mode information handling. > > >=20 > > > --- a/lib/librte_ethdev/rte_ethdev.h > > > +++ b/lib/librte_ethdev/rte_ethdev.h > > > /** > > > - * Burst mode types, values can be ORed to define the burst mode of = a driver. > > > + * Generic Burst mode flag definition, values can be ORed. > > > + */ > > > +#define RTE_ETH_BURST_FLAG_PER_QUEUE (1ULL << 0) > > > +/**< If the queues have different burst mode description, this bit w= ill be set > > > + * by PMD, then the application can iterate to retrieve burst descri= ption for > > > + * all other queues. > > > */ > > > > I am not sure you can have a doxygen comment before and after the same = item. > > >=20 > The first is for all flags, but only one now, so looks like for the same = item. > The second is just for RTE_ETH_BURST_FLAG_PER_QUEUE flag. >=20 Yes, you are right. I misunderstand the doxygen's grammar. Its output is tw= o comments together. RTE_ETH_BURST_FLAG_PER_QUEUE #define RTE_ETH_BURST_FLAG_PER_QUEUE (1ULL << 0) Generic Burst mode flag definition, values can be ORed. If the queues have = different burst mode description, this bit will be set by PMD, then the app= lication can iterate to retrieve burst description for all other queues. Definition at line 1253 of file rte_ethdev.h. I submit a new patch, change the first line to C comment. Now the output is= : RTE_ETH_BURST_FLAG_PER_QUEUE #define RTE_ETH_BURST_FLAG_PER_QUEUE (1ULL << 0) If the queues have different burst mode description, this bit will be set b= y PMD, then the application can iterate to retrieve burst description for a= ll other queues. Definition at line 1257 of file rte_ethdev.h. >=20 > >