From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37358A04B4; Fri, 8 Nov 2019 15:02:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 975DA1C132; Fri, 8 Nov 2019 15:02:11 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 59E561C0B5 for ; Fri, 8 Nov 2019 15:02:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Nov 2019 06:02:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,281,1569308400"; d="scan'208";a="232794282" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 08 Nov 2019 06:02:00 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 Nov 2019 06:01:56 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 Nov 2019 06:01:56 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.108]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.41]) with mapi id 14.03.0439.000; Fri, 8 Nov 2019 22:01:54 +0800 From: "Wang, Haiyue" To: Thomas Monjalon CC: "dev@dpdk.org" , "olivier.matz@6wind.com" , "Ye, Xiaolong" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API Thread-Index: AQHVlVkh3iu4v6QT1Ea1hIuvZbOCqqeAtsCAgACV8FA= Date: Fri, 8 Nov 2019 14:01:53 +0000 Message-ID: References: <20191105011918.53434-1-haiyue.wang@intel.com> <20191107104402.99398-1-haiyue.wang@intel.com> <3014726.q9f2PGURN9@xps> In-Reply-To: <3014726.q9f2PGURN9@xps> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzNhMmE2MzItNTc4Ni00ODA3LTk0OTUtNmY4YWI4YTQxY2NlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNkV4WjBORWI4VG9cL2czMDRHeG0rOFR5c3RjdzRZK2dHdnBCUE44XC92ZGtxYkZTXC9cLzBDRUdlY29XeERLZFwvMFVlIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Friday, November 8, 2019 20:55 > To: Wang, Haiyue > Cc: dev@dpdk.org; olivier.matz@6wind.com; Ye, Xiaolong ; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction = by dynamic mbuf API >=20 > 07/11/2019 11:44, Haiyue Wang: > > --- a/drivers/net/ice/rte_pmd_ice_version.map > > +++ b/drivers/net/ice/rte_pmd_ice_version.map > > +EXPERIMENTAL { > > + global: > > + > > + # added in 19.11 > > + rte_net_ice_dynfield_proto_xtr_metadata_offs; > > + rte_net_ice_dynflag_proto_xtr_vlan_mask; > > + rte_net_ice_dynflag_proto_xtr_ipv4_mask; > > + rte_net_ice_dynflag_proto_xtr_ipv6_mask; > > + rte_net_ice_dynflag_proto_xtr_ipv6_flow_mask; > > + rte_net_ice_dynflag_proto_xtr_tcp_mask; > > +}; >=20 > Given that you provide some functions to access to the metadata, > why do you need to export these flags and field in the .map? > > However, the functions are missing in the .map. > Did you try to compile as a shared library? >=20 These functions are 'static inline', no need to be exported in the .map. And the macros like 'PKT_RX_DYNF_PROTO_XTR_XXX', in fact, their real definitions are global values defined in rte_pmd_ice like: rte_net_ice_dynflag_proto_xtr_xxx_mask. Since rte_pmd_ice are required to compiled as a shared library, so it is needed to export these flags and field in the .map. This design is referred to the below upstream practice about dynamic mbuf. commit 7743e81854944ed17df05bfdcba26556cb41ca0c Author: Viacheslav Ovsiienko Date: Tue Nov 5 14:19:30 2019 +0000 ethdev: extend flow metadata --- a/lib/librte_ethdev/rte_ethdev_version.map +++ b/lib/librte_ethdev/rte_ethdev_version.map @@ -289,4 +289,7 @@ EXPERIMENTAL { rte_eth_rx_hairpin_queue_setup; rte_eth_tx_burst_mode_get; rte_eth_tx_hairpin_queue_setup; + rte_flow_dynf_metadata_offs; + rte_flow_dynf_metadata_mask; + rte_flow_dynf_metadata_register; };