From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Ye, Xiaolong" <xiaolong.ye@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] net/ice: align with MAC address length definition
Date: Fri, 3 Jan 2020 01:15:49 +0000 [thread overview]
Message-ID: <E3B9F2FDCB65864C82CD632F23D8AB8773DB4EBF@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20200102093630.6811a8af@hermes.lan>
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Friday, January 3, 2020 01:37
> To: Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; Ye, Xiaolong <xiaolong.ye@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1] net/ice: align with MAC address length definition
>
> On Thu, 2 Jan 2020 15:14:57 +0800
> Haiyue Wang <haiyue.wang@intel.com> wrote:
>
> > Use the standand MAC address length definition in PMD's scope.
> >
> > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> > ---
> > drivers/net/ice/ice_ethdev.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> > index 2cbd82c94..80b422a27 100644
> > --- a/drivers/net/ice/ice_ethdev.c
> > +++ b/drivers/net/ice/ice_ethdev.c
> > @@ -873,7 +873,7 @@ ice_add_mac_filter(struct ice_vsi *vsi, struct rte_ether_addr *mac_addr)
> > ret = -ENOMEM;
> > goto DONE;
> > }
> > - rte_memcpy(&f->mac_info.mac_addr, mac_addr, ETH_ADDR_LEN);
> > + rte_memcpy(&f->mac_info.mac_addr, mac_addr, RTE_ETHER_ADDR_LEN);
>
> Please use rte_ether_addr_copy instead.
Will be update patch v2.
next prev parent reply other threads:[~2020-01-03 1:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 7:14 Haiyue Wang
2020-01-02 14:01 ` Zhang, Qi Z
2020-01-02 17:36 ` Stephen Hemminger
2020-01-03 1:15 ` Wang, Haiyue [this message]
2020-01-03 2:02 ` [dpdk-dev] [PATCH v2] net/ice: use the copy API to do MAC assignment Haiyue Wang
2020-01-03 2:23 ` Yang, Qiming
2020-01-03 2:59 ` Wang, Haiyue
2020-01-03 2:58 ` [dpdk-dev] [PATCH v3] " Haiyue Wang
2020-01-06 2:45 ` Yang, Qiming
2020-01-13 8:05 ` Ye Xiaolong
2020-01-13 8:29 ` Wang, Haiyue
2020-01-13 8:22 ` [dpdk-dev] [PATCH v4] " Haiyue Wang
2020-01-13 8:32 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E3B9F2FDCB65864C82CD632F23D8AB8773DB4EBF@shsmsx102.ccr.corp.intel.com \
--to=haiyue.wang@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).