From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8761AA04F3; Fri, 3 Jan 2020 02:15:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B70B91C1E3; Fri, 3 Jan 2020 02:15:55 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 662F11C1DB for ; Fri, 3 Jan 2020 02:15:52 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2020 17:15:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,388,1571727600"; d="scan'208";a="421300458" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 02 Jan 2020 17:15:51 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Jan 2020 17:15:51 -0800 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Jan 2020 17:15:51 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.202]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.132]) with mapi id 14.03.0439.000; Fri, 3 Jan 2020 09:15:49 +0800 From: "Wang, Haiyue" To: Stephen Hemminger CC: "dev@dpdk.org" , "Ye, Xiaolong" Thread-Topic: [dpdk-dev] [PATCH v1] net/ice: align with MAC address length definition Thread-Index: AQHVwT1NZr8baZCE4kem7aOL8Sym+afXHb4AgAEGVSA= Date: Fri, 3 Jan 2020 01:15:49 +0000 Message-ID: References: <20200102071457.106137-1-haiyue.wang@intel.com> <20200102093630.6811a8af@hermes.lan> In-Reply-To: <20200102093630.6811a8af@hermes.lan> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] net/ice: align with MAC address length definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Stephen Hemminger > Sent: Friday, January 3, 2020 01:37 > To: Wang, Haiyue > Cc: dev@dpdk.org; Ye, Xiaolong > Subject: Re: [dpdk-dev] [PATCH v1] net/ice: align with MAC address length= definition >=20 > On Thu, 2 Jan 2020 15:14:57 +0800 > Haiyue Wang wrote: >=20 > > Use the standand MAC address length definition in PMD's scope. > > > > Signed-off-by: Haiyue Wang > > --- > > drivers/net/ice/ice_ethdev.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.= c > > index 2cbd82c94..80b422a27 100644 > > --- a/drivers/net/ice/ice_ethdev.c > > +++ b/drivers/net/ice/ice_ethdev.c > > @@ -873,7 +873,7 @@ ice_add_mac_filter(struct ice_vsi *vsi, struct rte_= ether_addr *mac_addr) > > ret =3D -ENOMEM; > > goto DONE; > > } > > - rte_memcpy(&f->mac_info.mac_addr, mac_addr, ETH_ADDR_LEN); > > + rte_memcpy(&f->mac_info.mac_addr, mac_addr, RTE_ETHER_ADDR_LEN); >=20 > Please use rte_ether_addr_copy instead. Will be update patch v2.