From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97CB1A04F3; Fri, 3 Jan 2020 03:59:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 788251C1FD; Fri, 3 Jan 2020 03:59:54 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 6ADAA1C1FC for ; Fri, 3 Jan 2020 03:59:53 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2020 18:59:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,389,1571727600"; d="scan'208";a="214332297" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga008.jf.intel.com with ESMTP; 02 Jan 2020 18:59:52 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Jan 2020 18:59:52 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Jan 2020 18:59:52 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.202]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.210]) with mapi id 14.03.0439.000; Fri, 3 Jan 2020 10:59:51 +0800 From: "Wang, Haiyue" To: "Yang, Qiming" , "dev@dpdk.org" , "stephen@networkplumber.org" , "Zhang, Qi Z" , "Ye, Xiaolong" Thread-Topic: [dpdk-dev] [PATCH v2] net/ice: use the copy API to do MAC assignment Thread-Index: AQHVwdrkdRd9U7Eea0GE5M+6yd5Fu6fXr7wAgACP/tA= Date: Fri, 3 Jan 2020 02:59:50 +0000 Message-ID: References: <20200102071457.106137-1-haiyue.wang@intel.com> <20200103020204.11356-1-haiyue.wang@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ice: use the copy API to do MAC assignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yang, Qiming > Sent: Friday, January 3, 2020 10:23 > To: Wang, Haiyue ; dev@dpdk.org; stephen@networkpl= umber.org; Zhang, Qi Z > ; Ye, Xiaolong > Cc: Wang, Haiyue > Subject: RE: [dpdk-dev] [PATCH v2] net/ice: use the copy API to do MAC as= signment >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Haiyue Wang > > Sent: Friday, January 3, 2020 10:02 AM > > To: dev@dpdk.org; stephen@networkplumber.org; Zhang, Qi Z > > ; Ye, Xiaolong > > Cc: Wang, Haiyue > > Subject: [dpdk-dev] [PATCH v2] net/ice: use the copy API to do MAC > > assignment > > > > Use the fast copy an Ethernet address API to do MAC assignment, instead= of >=20 > I think the grammar is not right. Do you want to say 'Use rte_ether_addr_= copy API to copy an Ethernet > address'? Yes, I copied the rte_ether_addr_copy's comment 'Fast copy an Ethernet addr= ess. ' ;-) >=20 > > calling rte_memcpy function. > > > > Signed-off-by: Haiyue Wang > > --- > > v2: Update the commit title and message, use the rte_ether_addr_copy AP= I > > instead of just changing the length definition to make code style c= lean. > > > > drivers/net/ice/ice_ethdev.c | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.= c index > > 2cbd82c94..d104df26f 100644 > > --- a/drivers/net/ice/ice_ethdev.c > > +++ b/drivers/net/ice/ice_ethdev.c > > @@ -873,7 +873,7 @@ ice_add_mac_filter(struct ice_vsi *vsi, struct > > rte_ether_addr *mac_addr) > > ret =3D -ENOMEM; > > goto DONE; > > } > > - rte_memcpy(&f->mac_info.mac_addr, mac_addr, ETH_ADDR_LEN); > > + rte_ether_addr_copy(mac_addr, &f->mac_info.mac_addr); > > TAILQ_INSERT_TAIL(&vsi->mac_list, f, next); > > vsi->mac_num++; > > > > @@ -1660,16 +1660,16 @@ ice_setup_vsi(struct ice_pf *pf, enum > > ice_vsi_type type) > > > > if (type =3D=3D ICE_VSI_PF) { > > /* MAC configuration */ > > - rte_memcpy(pf->dev_addr.addr_bytes, > > - hw->port_info->mac.perm_addr, > > - ETH_ADDR_LEN); > > + rte_ether_addr_copy((struct rte_ether_addr *) > > + hw->port_info->mac.perm_addr, > > + &pf->dev_addr); > > > > - rte_memcpy(&mac_addr, &pf->dev_addr, > > RTE_ETHER_ADDR_LEN); > > + rte_ether_addr_copy(&pf->dev_addr, &mac_addr); > > ret =3D ice_add_mac_filter(vsi, &mac_addr); > > if (ret !=3D ICE_SUCCESS) > > PMD_INIT_LOG(ERR, "Failed to add dflt MAC filter"); > > > > - rte_memcpy(&mac_addr, &broadcast, > > RTE_ETHER_ADDR_LEN); > > + rte_ether_addr_copy(&broadcast, &mac_addr); > > ret =3D ice_add_mac_filter(vsi, &mac_addr); > > if (ret !=3D ICE_SUCCESS) > > PMD_INIT_LOG(ERR, "Failed to add MAC filter"); @@ > > -3267,7 +3267,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev, > > PMD_DRV_LOG(ERR, "Failed to add mac filter"); > > return -EIO; > > } > > - memcpy(&pf->dev_addr, mac_addr, ETH_ADDR_LEN); > > + rte_ether_addr_copy(mac_addr, &pf->dev_addr); > > > > flags =3D ICE_AQC_MAN_MAC_UPDATE_LAA_WOL; > > ret =3D ice_aq_manage_mac_write(hw, mac_addr->addr_bytes, flags, > > NULL); > > -- > > 2.17.1