From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6B6BA04AD; Fri, 1 May 2020 16:41:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4DB191DA6D; Fri, 1 May 2020 16:41:09 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 91E3B1DA6C for ; Fri, 1 May 2020 16:41:06 +0200 (CEST) IronPort-SDR: 0GOhhfzwbfia1e8Fiq3RkH0moqjItWly7FfoAOU8CzeyuInycHTN9np3fpjjwz07hWmFlfBLLg aE1FiZyqu4rw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2020 07:41:05 -0700 IronPort-SDR: 9UfdYh3hhsdNvvS22HjWout1AY8H9VDX7AifKM4iZPhqj0J/gKBx4CKPEe3FLMHCcHUdPt361G qElkdxKi6zYQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,339,1583222400"; d="scan'208";a="460280010" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by fmsmga006.fm.intel.com with ESMTP; 01 May 2020 07:41:04 -0700 Received: from orsmsx155.amr.corp.intel.com (10.22.240.21) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 1 May 2020 07:41:04 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX155.amr.corp.intel.com (10.22.240.21) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 1 May 2020 07:41:04 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 1 May 2020 07:41:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dNDkGudJ5GQhkS3kT6ELW08StAB5qY1LQpByAQNIlQbvxkJxajTxDJJrrCBrc7LTE36fjnQi7CAB0oVq3lUo/dQTIrTc9b1PTA6zoihYxFBYvf8I5wvJd0HrYLQJHvDdXVrXcWFuX9fZAV2kQ0ljelCioVQIyW/64sUv4F3NEMGE6pkmeJJMr64YiHkGnoJpW2BtbclbzsB3rSo5Lt5BEy1PfwcdcRdHl6StuwXSbEWobKhybsdnm1FXuo5Q74uG5mWkoFFNHlt41qDp5t43FMRmINQRyiBypIcazK7FZ5vyHP/O/Yii8cNnTMA/sYZ+7J3hTc2wgcS1RDW+rUyi2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qZwwerWcYMtn+GrYVNJcerWq+88sKPFN0FZjEHYW0tE=; b=n6JPsYTUe84Qyfsk14AGKyxrEiZ/bgTiF1pgtUXlEasuKfxwNbGtkHcVv1Fj73yKlnZ3f6gJTBPqFJzkPEnB4o+Ykq73a8fisui8Af1i49k3w5v//df5NFlSnIR8Aw4KQXXKPVP3iUclDF49wrOLDuTREcTtxj3Pck8MFRgxSUxyiYQ1th6ru8Jii8TX4uyD69KTTGAHhczJSGDLPmpYfEGaqmfdLyRyb7h56Oh8pytQc+HsxPCN2oKv7+qB32bajNEiNpiUPWJG8dxlT8H2aMGOSYl1ywuctRdvCqX1wy4pPOHCkTmBpAW/D815pW9VDB96ejhjFGOWlQYbZWbAbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qZwwerWcYMtn+GrYVNJcerWq+88sKPFN0FZjEHYW0tE=; b=YZjG78y9yYWyQutuyBkQMlPvPg+XvScOn+781QY9gWyIArZTBBG2a4t3oYWe+zECC6xrVnLndfGLayQ3qrOOX0rllB9amQuo23Cph2Gi+Rg+3ncf7X2ahLkksPlApgSjQuOeLyqHBSIe4kI1Xs4gKgAhbIruPGnnFpDPLCv4IfE= Received: from DM6PR11MB4593.namprd11.prod.outlook.com (2603:10b6:5:2a3::8) by DM6PR11MB3322.namprd11.prod.outlook.com (2603:10b6:5:55::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Fri, 1 May 2020 14:41:02 +0000 Received: from DM6PR11MB4593.namprd11.prod.outlook.com ([fe80::acee:4fa2:2a9e:7cd6]) by DM6PR11MB4593.namprd11.prod.outlook.com ([fe80::acee:4fa2:2a9e:7cd6%3]) with mapi id 15.20.2958.027; Fri, 1 May 2020 14:41:02 +0000 From: "Wiles, Keith" To: "Power, Ciara" CC: dev , "Laatz, Kevin" , "Pattan, Reshma" , "jerinjacobk@gmail.com" , "david.marchand@redhat.com" , "mb@smartsharesystems.com" , "thomas@monjalon.net" , "stephen@networkplumber.org" , "bluca@debian.org" Thread-Topic: [PATCH v5 00/18] update and simplify telemetry library. Thread-Index: AQHWHwjK5G9tIftPBU6bG0u6Q3sbpKiTTv+A Date: Fri, 1 May 2020 14:41:02 +0000 Message-ID: References: <20200319171907.60891-1-ciara.power@intel.com> <20200430160137.59135-1-ciara.power@intel.com> In-Reply-To: <20200430160137.59135-1-ciara.power@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [134.134.136.206] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 50b2e19e-0a64-4616-d93f-08d7edddabc8 x-ms-traffictypediagnostic: DM6PR11MB3322: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0390DB4BDA x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4593.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(346002)(136003)(376002)(396003)(39860400002)(366004)(2906002)(186003)(5660300002)(54906003)(33656002)(15650500001)(6486002)(86362001)(6506007)(36756003)(76116006)(8936002)(53546011)(64756008)(26005)(66946007)(66476007)(91956017)(8676002)(66446008)(316002)(478600001)(966005)(66556008)(4326008)(37006003)(6512007)(6862004)(71200400001)(2616005)(6636002); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UFV9llIRq4UARjGe20cvVU2p69QbbHRj0C7Q465z6X8qTn9+PFGyglYTMNSimPK6nwoKnKxPPPdtpyj92KDxTllg+Mfvbh3Wa1lAvToRvcqUfmrTREvMU4iVmcp3Plbgiw0iHxu+b8Zojmvd+c5fOVg9+QC3iG3+fbO2jVyDMgh1zGgbWKR18l+5GhfWY3248qRGiwuSmok9SZcOEeDKqjsvWyXMKtu5kmNTlfa/ddbMnE4QC/j1InUo8G0dZds16wY7JB1+7butYoapXew68mDln7WCDQOJPUupuVBeUYCaJEcTq5Jl6x8iFxEukUk0Nfkf2WlpkNfOS9ETR49s99Q5+BN++I+WSmd4/E/t2YGpPHCd+zFPcidZoeYBd5n6JHDcMHUROyDuyOqlZP2k3SA9ksgEdm8Fd1RR3CXZ7BroEzsRFQjQDDjAFbls4AWJH8GGdZPZYzBdmpPlWpXEcLNfBkx1UvkdadVeuhKFwiV9gkYCzik/DIe5jsqoOk7m5T8Mn3ZwQL/VB3uc3+0nSg== x-ms-exchange-antispam-messagedata: UaQ/b9P5TOn682d8qYu/bQb8FpPlI+5K5CtHsHcErojL9aZv+w5uPV18a3bcausGRkaNGOsI9jBke1H5WlnBvfO4K1JxEIwdJx1pC3G7TxlUwIr9hLeyPsuyQabJHJXtGmQT91Yrkz70Wc1fxXVK8YS27/9ej/NiCQd88c75emhiuFqi4zp6Ryo+CqzZEwxK0c19nbnU1qlGaIowMbBIr4DB6hPvXhagLpS8k5FBx8wQiERQE5QMfg30pCoE3117xJjYZAFtvWqLSvAIZgYkNpMa75zgARRHwunSW1Ay3piw2fvTcJ0ZONn+kLXulWVVWxDbvsmLWJsn1SRZERs2YkycTltQbnwXueunKG7/IOJQtqpSv/ZZsS3UBwJAvzYeoTVTBFk6aFnBMWfq26EArRRIceDb+MYaS6zhIRetK1LSCofiX0Fz59KBSxKuXek8AVZHfzSZS2xEIKsGin1gtIrzA2gQ0enb2EKJmKaO6VARUM0g6yOQp86GWkiThFcd884MQ2ZG/ge8eYoFiGtUyCME2U0t9XGrloVrhJ5FLzRc3JMq+talthVCg+Cmrrdn0i94y7rGW1eC8tW77HT992WQX5IRddGzT6VbYhDAgVUd0lqku146SzxT+iC2hvfYDKmbrBaG0cdYOoKosxDebOWbz7akg6Nq8vukiGf9Vm9EFdRbdegXfTJg90t0ufaMHUhYlrnkR1uutZCPsSe81aqwo+Mr0BhBa2E1QhTQxsbKX/mshjcKTWE/M3YbcULJkS7vJssxMzuBXkSPfeCUAS6fmRPYcaVOTUyQeDd30SgtUerJJpxy1y3C82eH/Acj Content-Type: text/plain; charset="us-ascii" Content-ID: <7B0659C8522F0D4ABBCEAAC35A29FC41@namprd11.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 50b2e19e-0a64-4616-d93f-08d7edddabc8 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2020 14:41:02.1050 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RYytDXqzScD0nkXI/VPF3j092q62/tqU1FQXUCjEQutujtdQBTFM/q44ZbFJkAmKE39Azr9wSAgFeWsonkR0aQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3322 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5 00/18] update and simplify telemetry library. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Apr 30, 2020, at 11:01 AM, Power, Ciara wrote: >=20 > v5: > - General cleanup to address comments on v4 patchset. >=20 > v4: > - Internal representation now uses generic data format instead of JSON. > - Help command added to provide help text for a command. >=20 > v3: > - Removed rte_option as it is no longer used. > - General cleanup. >=20 > v2: > - Added JSON API, and unit tests, to simplify creation of valid json > responses from libraries. > - Added printing of basic info, including max output buffer size, app > PID and DPDK version on connection. > - Added /info command to report that basic info post-connect. This > replaces the eal version command from v1. > - Renamed stats to xstats in commands to allow a future generic > "stats" call. > - Added documentation, including updating existing howto and adding > programmers guide section and API docs. > - Added link status command for ethdev ports. > - Fixed windows builds. >=20 > This patchset extensively reworks the telemetry library adding new > functionality and simplifying much of the existing code, while > maintaining backward compatibility. >=20 > This work is based on the previously sent RFC for a "process info" > library: https://patchwork.dpdk.org/project/dpdk/list/?series=3D7741 > However, rather than creating a new library, this patchset takes > that work and merges it into the existing telemetry library, as > mentioned above. >=20 > The telemetry library as shipped in 19.11 is based upon the metrics > library and outputs all statistics based on that as a source. However, > this limits the telemetry output to only port-level statistics > information, rather than allowing it to be used as a general scheme for > telemetry information across all DPDK libraries. >=20 > With this patchset applied, rather than the telemetry library being > responsible for pulling ethdev stats and pushing them into the metrics > library for retrieval later, each library e.g. ethdev, rawdev, and even > the metrics library itself (for backwards compatiblity) now handle their > own stats. Any library or app can register a callback function with > telemetry, which will be called if requested by the client connected via > the telemetry socket. The callback function in the library/app then > formats its stats, or other data, into a generic data structure, and > returns it to telemetry to be sent to the client in JSON format. >=20 > To maintain backward compatibility, e.g. to allow the dpdk telemetry > collectd plugin to continue to work, some of the existing telemetry > code is kept, but is moved into the metrics library, and callbacks are > registered with telemetry for the legacy commands that were supported > previously. >=20 > The new version of the library, apart from the legacy interface support > for backward compatibility, does not have an external dependency on the > Jansson library, allowing the library to be enabled by default. >=20 > Note: In this version of the patchset, telemetry output is provided by > the ethdev, rawdev and eal libraries, but this may be expanded further > in later versions which are planned ahead of the merge deadline for > 20.05 >=20 > Bruce Richardson (8): > build: add arch-specific header path to global includes > telemetry: invert dependency on metrics > telemetry: add utility functions for creating json > telemetry: introduce new telemetry functionality > telemetry: add functions for returning callback data > usertools: add new telemetry python script > ethdev: add callback support for telemetry > eal: add eal telemetry callbacks >=20 > Ciara Power (10): > telemetry: move code to metrics for later reuse > metrics: reduce code taken from telemetry > telemetry: add default callback commands > rawdev: add callback support for telemetry > examples/l3fwd-power: enable use of new telemetry > telemetry: introduce telemetry backward compatibility > telemetry: remove existing telemetry files > lib: add telemetry as eal dependency > eal: remove rte-option infrastructure > doc: update telemetry documentation >=20 For the few items I noted in my review, these have been corrected. Acked-by: Keith Wiles