DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] pktgen: enable RSS on versions of DPDK after 18.05
@ 2019-06-06 21:45 David Christensen
  2019-06-06 22:07 ` Wiles, Keith
  0 siblings, 1 reply; 2+ messages in thread
From: David Christensen @ 2019-06-06 21:45 UTC (permalink / raw)
  To: keith.wiles; +Cc: dev, David Christensen

When backwards compatibility was added for earlier releases of DPDK,
default enablement of RSS was lost for versions of DPDK after 18.05.
This change restores the old behavior and enables RSS by default.

Fixes: ae81c62f194c ("backward compat to 18.02 at least")
Cc: keith.wiles@intel.com

Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
---
 app/pktgen-port-cfg.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/app/pktgen-port-cfg.c b/app/pktgen-port-cfg.c
index fb2873e..b5bded7 100644
--- a/app/pktgen-port-cfg.c
+++ b/app/pktgen-port-cfg.c
@@ -64,6 +64,12 @@ static struct rte_eth_conf default_port_conf = {
 		.offloads = DEV_RX_OFFLOAD_CRC_STRIP,
 #endif
 	},
+	.rx_adv_conf = {
+		.rss_conf = {
+			.rss_key = NULL,
+			.rss_hf = ETH_RSS_IP,
+		},
+	},
 	.txmode = {
 		.mq_mode = ETH_MQ_TX_NONE,
 	},
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] pktgen: enable RSS on versions of DPDK after 18.05
  2019-06-06 21:45 [dpdk-dev] [PATCH] pktgen: enable RSS on versions of DPDK after 18.05 David Christensen
@ 2019-06-06 22:07 ` Wiles, Keith
  0 siblings, 0 replies; 2+ messages in thread
From: Wiles, Keith @ 2019-06-06 22:07 UTC (permalink / raw)
  To: David Christensen; +Cc: dev



> On Jun 6, 2019, at 4:45 PM, David Christensen <drc@linux.vnet.ibm.com> wrote:
> 
> When backwards compatibility was added for earlier releases of DPDK,
> default enablement of RSS was lost for versions of DPDK after 18.05.
> This change restores the old behavior and enables RSS by default.
> 
> Fixes: ae81c62f194c ("backward compat to 18.02 at least")
> Cc: keith.wiles@intel.com
> 
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> ---
> app/pktgen-port-cfg.c | 6 ++++++
> 1 file changed, 6 insertions(+)
> 
> diff --git a/app/pktgen-port-cfg.c b/app/pktgen-port-cfg.c
> index fb2873e..b5bded7 100644
> --- a/app/pktgen-port-cfg.c
> +++ b/app/pktgen-port-cfg.c
> @@ -64,6 +64,12 @@ static struct rte_eth_conf default_port_conf = {
> 		.offloads = DEV_RX_OFFLOAD_CRC_STRIP,
> #endif
> 	},
> +	.rx_adv_conf = {
> +		.rss_conf = {
> +			.rss_key = NULL,
> +			.rss_hf = ETH_RSS_IP,
> +		},
> +	},

Thanks for the patch.
> 	.txmode = {
> 		.mq_mode = ETH_MQ_TX_NONE,
> 	},
> -- 
> 1.8.3.1
> 

Regards,
Keith


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-06 22:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-06 21:45 [dpdk-dev] [PATCH] pktgen: enable RSS on versions of DPDK after 18.05 David Christensen
2019-06-06 22:07 ` Wiles, Keith

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).