From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 17B9DA0096 for ; Fri, 7 Jun 2019 00:07:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D53E41B958; Fri, 7 Jun 2019 00:07:55 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 332951B957 for ; Fri, 7 Jun 2019 00:07:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2019 15:07:53 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 06 Jun 2019 15:07:52 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 6 Jun 2019 15:07:52 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.141]) by FMSMSX112.amr.corp.intel.com ([169.254.5.219]) with mapi id 14.03.0415.000; Thu, 6 Jun 2019 15:07:52 -0700 From: "Wiles, Keith" To: David Christensen CC: "dev@dpdk.org" Thread-Topic: [PATCH] pktgen: enable RSS on versions of DPDK after 18.05 Thread-Index: AQHVHLExzSeCIYxJxE64+BquoBXcFqaPpIaA Date: Thu, 6 Jun 2019 22:07:52 +0000 Message-ID: References: <1559857522-339-1-git-send-email-drc@linux.vnet.ibm.com> In-Reply-To: <1559857522-339-1-git-send-email-drc@linux.vnet.ibm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.75.4] Content-Type: text/plain; charset="us-ascii" Content-ID: <7C5C792B408A8F46935F9809238635D0@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] pktgen: enable RSS on versions of DPDK after 18.05 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Jun 6, 2019, at 4:45 PM, David Christensen wr= ote: >=20 > When backwards compatibility was added for earlier releases of DPDK, > default enablement of RSS was lost for versions of DPDK after 18.05. > This change restores the old behavior and enables RSS by default. >=20 > Fixes: ae81c62f194c ("backward compat to 18.02 at least") > Cc: keith.wiles@intel.com >=20 > Signed-off-by: David Christensen > --- > app/pktgen-port-cfg.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/app/pktgen-port-cfg.c b/app/pktgen-port-cfg.c > index fb2873e..b5bded7 100644 > --- a/app/pktgen-port-cfg.c > +++ b/app/pktgen-port-cfg.c > @@ -64,6 +64,12 @@ static struct rte_eth_conf default_port_conf =3D { > .offloads =3D DEV_RX_OFFLOAD_CRC_STRIP, > #endif > }, > + .rx_adv_conf =3D { > + .rss_conf =3D { > + .rss_key =3D NULL, > + .rss_hf =3D ETH_RSS_IP, > + }, > + }, Thanks for the patch. > .txmode =3D { > .mq_mode =3D ETH_MQ_TX_NONE, > }, > --=20 > 1.8.3.1 >=20 Regards, Keith