From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20074.outbound.protection.outlook.com [40.107.2.74]) by dpdk.org (Postfix) with ESMTP id 5AD8F27D for ; Wed, 27 Feb 2019 00:05:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TLBmT3XyCRY310kcrZsuLSow4VH/7kwbPhwFELownKg=; b=qLRy3RBcZedL4I2eXbkQ7HqcONISo+yce40YnQDMDj3mM7yxSy/76yU3SHf7MCqXyGjOhUVVdjLLnWd48ufMJ1wfhsEAyI8Iq23HUI0WciAJqriyrK9aaJX7mUR5+2xNpvb+nr4+XSFtjGMcgQy6YgYpOSNtsNi7M8huYZ4kqZ4= Received: from AM0PR08MB3379.eurprd08.prod.outlook.com (20.177.109.142) by AM0PR08MB4595.eurprd08.prod.outlook.com (20.178.83.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.14; Tue, 26 Feb 2019 23:05:22 +0000 Received: from AM0PR08MB3379.eurprd08.prod.outlook.com ([fe80::6928:7050:50fa:dedf]) by AM0PR08MB3379.eurprd08.prod.outlook.com ([fe80::6928:7050:50fa:dedf%3]) with mapi id 15.20.1643.019; Tue, 26 Feb 2019 23:05:22 +0000 From: Dharmik Thakkar To: Stephen Hemminger CC: "dev@dpdk.org" , nd Thread-Topic: [dpdk-dev] [PATCH v3 0/3] Replace compilation time options with log level Thread-Index: AQHUyXAXfGlPbeOMbEukVMNJPw2oXaXpT3qAgAltJIA= Date: Tue, 26 Feb 2019 23:05:22 +0000 Message-ID: References: <20190220224714.16303-1-dharmik.thakkar@arm.com> <20190220230023.17029-1-dharmik.thakkar@arm.com> <20190220150823.69a3cb3e@shemminger-XPS-13-9360> In-Reply-To: <20190220150823.69a3cb3e@shemminger-XPS-13-9360> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Dharmik.Thakkar@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 861a1901-b9b0-42cf-7b06-08d69c3ee2a1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR08MB4595; x-ms-traffictypediagnostic: AM0PR08MB4595: nodisclaimer: True x-microsoft-exchange-diagnostics: 1; AM0PR08MB4595; 20:t4rqsHtXpYFyKzz8q7hywH3xlEmRVmB4E7+hrk+TwaRI1LrNpNgUUfgPs7T/rwOSDu0pY5yB9RuGX4vqviE+9/t4nMb9wsYwFGa1qSKPxlqccT4TL81DCjCScouYXxdOmjs4Q7cIhs2HpE3srwHA/L+E7J6h3ZFN9Ry7AkH04nI= x-microsoft-antispam-prvs: x-forefront-prvs: 096029FF66 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(136003)(376002)(396003)(366004)(189003)(199004)(53936002)(2906002)(8676002)(53546011)(186003)(36756003)(478600001)(256004)(14454004)(6506007)(3846002)(97736004)(229853002)(316002)(6116002)(6916009)(33656002)(82746002)(4744005)(72206003)(66066001)(105586002)(11346002)(6246003)(99286004)(6436002)(8936002)(2616005)(106356001)(486006)(76176011)(446003)(305945005)(476003)(4326008)(5660300002)(7736002)(6512007)(26005)(68736007)(6486002)(71200400001)(54906003)(81156014)(81166006)(71190400001)(102836004)(86362001)(25786009)(83716004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB4595; H:AM0PR08MB3379.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ppvvX0lv2aQje0DFka2htPC1rriOYt1pz6feJsjVoPr58sS2Dc7A0VJpYyTxGiA5u7e63fXpHTYSrQTohjvpmd9/yUOyECnyrkDQjY1la/mzqFl/Hn3D4yGoEjS25AODT4sP0pGpsLLyuUAD9sUHa8xqBZJKbNvfhuT/FIT+Y6j3EzvI3jAJHvlvKUeQUorC8bJXxhJq4NsR+KBcro+pNBUB1xg59d99knoW4jokaX1uo+Shp2HyzhG7kjDtB9O5YjXT6d1Ggw6f9B89tMdOHt1IJgLOohe7BNfIyuHOcH4qut4qpytqJrLZJaRir38LGGK0nN9BHQVUmiCAgShAlQ+kCKLV3PGRb4IO0kqUdFRx2za2CvXPRodGnd9siG2x+sZsi1owFnlX0zBkoRhiJIuOYJ2GzZQ2nmC7S5rYl20= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 861a1901-b9b0-42cf-7b06-08d69c3ee2a1 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Feb 2019 23:05:22.2271 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4595 Subject: Re: [dpdk-dev] [PATCH v3 0/3] Replace compilation time options with log level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 23:05:23 -0000 > On Feb 20, 2019, at 5:08 PM, Stephen Hemminger wrote: >=20 > On Wed, 20 Feb 2019 17:00:20 -0600 > Dharmik Thakkar wrote: >=20 >> Currently, in test code, for printing extra information, >> compilation time options are used. This approach does not compile the >> code always. Macro needs to be set for the code to compile. >>=20 >> This patchset replaces compilation time option with log level based >> approach, thus enabling compilation of code always. Log levels can be >> set using eal parameters. >>=20 >> Dharmik Thakkar (3): >> test/hash: replace macro with log-level approach >> test/efd: enable unit test compilation always >> test/timer: enable unit test compilation always >>=20 >> test/test/test_efd.c | 24 ++++++++---------------- >> test/test/test_hash.c | 3 +-- >> test/test/test_timer_racecond.c | 23 ++++++++++------------- >> 3 files changed, 19 insertions(+), 31 deletions(-) >>=20 >=20 > Maybe the tests should use their own dynamic logging (i.e. --log-level=3D= test.hash:debug) Updated. Thank you!