From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id DF9F5239; Fri, 8 Mar 2019 17:33:15 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Mar 2019 08:33:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,456,1544515200"; d="scan'208";a="150540032" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 08 Mar 2019 08:33:14 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 8 Mar 2019 08:33:14 -0800 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.143]) by fmsmsx123.amr.corp.intel.com ([169.254.7.3]) with mapi id 14.03.0415.000; Fri, 8 Mar 2019 08:33:14 -0800 From: "Wiles, Keith" To: olegpoly123 CC: Thomas Monjalon , dpdk-dev , "stable@dpdk.org" , Oeg Polyakov Thread-Topic: [PATCH v2 2/2] Define macro for iov_max default value Thread-Index: AQHU1cdyEQCcl53MMUanf759e7Y5bqYCc8yA Date: Fri, 8 Mar 2019 16:33:13 +0000 Message-ID: References: <20190308155547.1695-1-olegp123@walla.co.il> <20190308155547.1695-2-olegp123@walla.co.il> In-Reply-To: <20190308155547.1695-2-olegp123@walla.co.il> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.251.134.203] Content-Type: text/plain; charset="us-ascii" Content-ID: <1AC830B6E7014E46AF0D0D6427F3E283@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/2] Define macro for iov_max default value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Mar 2019 16:33:16 -0000 > On Mar 8, 2019, at 9:55 AM, olegpoly123 wrote: >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Oeg Polyakov > --- > drivers/net/tap/rte_eth_tap.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.= c > index cd48b2b2a..e7da73509 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -68,6 +68,8 @@ > /* IPC key for queue fds sync */ > #define TAP_MP_KEY "tap_mp_sync_queues" >=20 > +#define TAP_IOV_DEFAULT_MAX 1024 > + > static int tap_devices_count; > static struct rte_vdev_driver pmd_tap_drv; > static struct rte_vdev_driver pmd_tun_drv; > @@ -1328,8 +1330,8 @@ tap_rx_queue_setup(struct rte_eth_dev *dev, > long iov_max =3D sysconf(_SC_IOV_MAX); > if (iov_max <=3D 0) { > TAP_LOG(WARNING, > - "_SC_IOV_MAX is not defined. Using 1024 as default\n"); > - iov_max =3D 1024; > + "_SC_IOV_MAX is not defined. Using %d as default\n", TAP_IOV_DEFAULT_= MAX); > + iov_max =3D TAP_IOV_DEFAULT_MAX; I am afraid your patch will not work on top of the current code in the mast= er repo, it appears you created a patch on top of your v1 patch. Maybe you should squash the first patch and this one, then it should be cor= rect. > } > uint16_t nb_desc =3D RTE_MIN(nb_rx_desc, iov_max - 1); > struct iovec (*iovecs)[nb_desc + 1]; > --=20 > 2.14.1 >=20 Regards, Keith