From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 56D322FDD for ; Thu, 29 Oct 2015 10:54:20 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 29 Oct 2015 02:54:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,213,1444719600"; d="scan'208";a="674185932" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga003.jf.intel.com with ESMTP; 29 Oct 2015 02:54:18 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by irsmsx110.ger.corp.intel.com (163.33.3.25) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 29 Oct 2015 09:52:37 +0000 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.98]) by irsmsx111.ger.corp.intel.com ([169.254.2.212]) with mapi id 14.03.0248.002; Thu, 29 Oct 2015 09:52:37 +0000 From: "Van Haaren, Harry" To: "Sun, Xutao" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 0/2] i40e: Fix the statistics issue of i40e Thread-Index: AQHREiBXpV3V4C66xUmPVIfbCWe9956COBTQ Date: Thu, 29 Oct 2015 09:52:37 +0000 Message-ID: References: <1446096966-31815-1-git-send-email-xutao.sun@intel.com> <1446105751-28018-1-git-send-email-xutao.sun@intel.com> In-Reply-To: <1446105751-28018-1-git-send-email-xutao.sun@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-inteldataclassification: CTP_PUBLIC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsIiwiaWQiOiIxNTQ1Yjk5YS04NTgwLTQ4ZmEtYWE0ZS1kNTY5NWU5YmJmYTIiLCJwcm9wcyI6W3sibiI6IkludGVsRGF0YUNsYXNzaWZpY2F0aW9uIiwidmFscyI6W3sidmFsdWUiOiJDVFBfUFVCTElDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN25QaWtYRWJGT1NabTdIaVdIRmdJVXZkUGFMTFJTVlEybml5bDc1cWp2QT0ifQ== x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 0/2] i40e: Fix the statistics issue of i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2015 09:54:20 -0000 Hi Xutao, > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xutao Sun > Sent: Thursday, October 29, 2015 8:02 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 0/2] i40e: Fix the statistics issue of i40e >=20 > The old statistics on i40e only counted the packets on ports. > So the discarding packets on VSI were not counted. > This patch is to make statistics for packets both on ports and VSI. Indeed there is an issue in i40e stats, and adding the VSI stats to the por= t stats seems the right fix. > Xutao Sun (2): > i40e: Fix the statistics issue of i40e > doc: update release notes >=20 > doc/guides/rel_notes/release_2_1.rst | 5 +++++ > drivers/net/i40e/i40e_ethdev.c | 23 ++++++++++++++--------- > 2 files changed, 19 insertions(+), 9 deletions(-) It is preferred to update docs in the same patch as a bugfix: one patch sho= uld suffice for a bug-fix and adding a note that it has been fixed. Perhaps you edited the wrong release file? The next release changes are des= cribed in release_2_2.rst Would you send a v4 with release_2_2 updated, and then I'll test and ack? Cheers, -Harry