From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <harry.van.haaren@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 3D59AB62
 for <dev@dpdk.org>; Mon,  2 Nov 2015 11:17:15 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga103.fm.intel.com with ESMTP; 02 Nov 2015 02:17:14 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,234,1444719600"; d="scan'208";a="840996372"
Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66])
 by fmsmga002.fm.intel.com with ESMTP; 02 Nov 2015 02:17:13 -0800
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.98]) by
 IRSMSX152.ger.corp.intel.com ([169.254.6.38]) with mapi id 14.03.0248.002;
 Mon, 2 Nov 2015 10:17:12 +0000
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v4 02/10] ethdev: update xstats_get()
 strings and Q handling
Thread-Index: AQHREwdX23NHnw7i3E+eYj4N5U9/gp6IYroAgAAfcYA=
Date: Mon, 2 Nov 2015 10:17:12 +0000
Message-ID: <E923DB57A917B54B9182A2E928D00FA61282A4CF@IRSMSX102.ger.corp.intel.com>
References: <1445528914-27636-2-git-send-email-harry.van.haaren@intel.com>
 <1446204998-17151-1-git-send-email-harry.van.haaren@intel.com>
 <1446204998-17151-3-git-send-email-harry.van.haaren@intel.com>
 <1625667.g6rLv7AGl4@xps13>
In-Reply-To: <1625667.g6rLv7AGl4@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-inteldataclassification: CTP_PUBLIC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsIiwiaWQiOiI1ODk4YmE5NS0wOTc5LTRmZTktYjdkOS0zMTYyMDQ0Mzc4YTIiLCJwcm9wcyI6W3sibiI6IkludGVsRGF0YUNsYXNzaWZpY2F0aW9uIiwidmFscyI6W3sidmFsdWUiOiJDVFBfUFVCTElDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVyt2aWFWWFE0bFdOMk0zTnJ6aUFSUXRUT3kxSHNmUGxtTmp3SVBYWVAwaz0ifQ==
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4 02/10] ethdev: update xstats_get() strings
 and Q handling
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Nov 2015 10:17:15 -0000

Hi,

> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, November 2, 2015 7:59 AM
> > +       /* if xstats_get() is implemented by the PMD, the Q stats are d=
one */
> > +       if (dev->dev_ops->xstats_get !=3D NULL)
> > +               return count + xcount;
> > +
> >         /* per-rxq stats */
> >         for (q =3D 0; q < dev->data->nb_rx_queues; q++) {
> >                 for (i =3D 0; i < RTE_NB_RXQ_STATS; i++) {
>=20
> Please could you explain why the generic per-queue stats are not used whe=
n
> xstats is implemented in the driver?

Each PMD exposes its own queue stats so it has the flexibility of presentin=
g them exactly has the hardware counts, in a human-readable order.

If the generic xstats were used, testpmd> xstats output would split a singl=
e queue's xstats to two places in the list. As stats are used during debugg=
ing, readability and clarity of the stats is vital in my opinion.

-Harry