From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <harry.van.haaren@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 0B17B37AF
 for <dev@dpdk.org>; Mon, 16 Nov 2015 18:04:57 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga101.jf.intel.com with ESMTP; 16 Nov 2015 09:04:17 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,303,1444719600"; d="scan'208";a="852164120"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by fmsmga002.fm.intel.com with ESMTP; 16 Nov 2015 09:04:06 -0800
Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by
 IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Mon, 16 Nov 2015 17:03:59 +0000
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.251]) by
 irsmsx111.ger.corp.intel.com ([169.254.2.223]) with mapi id 14.03.0248.002;
 Mon, 16 Nov 2015 17:03:59 +0000
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Stephen Hemminger <shemming@brocade.com>
Thread-Topic: [PATCH 1/4] e1000: remove crc size from all byte counters
Thread-Index: AQHRIFqNCHIOgBrFFE+UIMNDwYvQ8p6e3kIAgAAB4lA=
Date: Mon, 16 Nov 2015 17:03:59 +0000
Message-ID: <E923DB57A917B54B9182A2E928D00FA61283812A@IRSMSX102.ger.corp.intel.com>
References: <1447670117-17723-1-git-send-email-harry.van.haaren@intel.com>
 <1447670117-17723-2-git-send-email-harry.van.haaren@intel.com>
 <20151116085440.3dca3ce0@samsung9>
In-Reply-To: <20151116085440.3dca3ce0@samsung9>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-inteldataclassification: CTP_PUBLIC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsIiwiaWQiOiJiMjUyNmQ0MS0yNjc3LTQwNTYtYjViZi02YjZiZGI3NTMyNWIiLCJwcm9wcyI6W3sibiI6IkludGVsRGF0YUNsYXNzaWZpY2F0aW9uIiwidmFscyI6W3sidmFsdWUiOiJDVFBfUFVCTElDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC9XUlg3K3pHU2kzcWM1amtzbm01ZFpDMlhGV21Eb1wvSURCUFVsT0pFbExNPSJ9
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/4] e1000: remove crc size from all byte
	counters
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Nov 2015 17:04:58 -0000

> From: Stephen Hemminger [mailto:shemming@brocade.com]
> Harry van Haaren <harry.van.haaren@intel.com> wrote:
> <snip>
> > +	stats->tor -=3D (stats->tpr - old_tpr) * 4;
>=20
> Why not use ETHER_CRC_LEN rather than magic # 4?

That would work too. Will respin tomorrow to fix and to give time
for other comments.

Thanks, -Harry