From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5D54FE62 for ; Tue, 15 Dec 2015 17:42:04 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 15 Dec 2015 08:42:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,433,1444719600"; d="scan'208";a="13631147" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga004.fm.intel.com with ESMTP; 15 Dec 2015 08:42:02 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.251]) by IRSMSX104.ger.corp.intel.com ([169.254.5.138]) with mapi id 14.03.0248.002; Tue, 15 Dec 2015 16:42:01 +0000 From: "Van Haaren, Harry" To: Robin Jarry Thread-Topic: [PATCH] ixgbe: restore imissed stat counter Thread-Index: AQHRN1KoPmJ/0KoLHk6C0pjV6JwDep7MPtrQ Date: Tue, 15 Dec 2015 16:41:59 +0000 Message-ID: References: <1450195501-9196-1-git-send-email-robin.jarry@6wind.com> In-Reply-To: <1450195501-9196-1-git-send-email-robin.jarry@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-inteldataclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsIiwiaWQiOiJkNDg1ZjBlYy01YzRhLTQ3ZDktYmYxNC0wM2VmNDk4NjFhMzEiLCJwcm9wcyI6W3sibiI6IkludGVsRGF0YUNsYXNzaWZpY2F0aW9uIiwidmFscyI6W3sidmFsdWUiOiJDVFBfSUMifV19XX0sIlN1YmplY3RMYWJlbHMiOltdLCJUTUNWZXJzaW9uIjoiMTUuNC4xMC4xOSIsIlRydXN0ZWRMYWJlbEhhc2giOiJiUWdCOGNIeVN2NzlHWWdRWDVJamhxejF5NFwvdllheTBpTDVCRnUzQ0lFND0ifQ== x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ixgbe: restore imissed stat counter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2015 16:42:04 -0000 > From: Robin Jarry [mailto:robin.jarry@6wind.com] > Subject: [PATCH] ixgbe: restore imissed stat counter >=20 > This counter was left unmodified. Restore it in ixgbe_dev_stats_get. >=20 > The ierrors counter still includes imissed for ixgbe. This behaviour is > not consistent amongst all drivers. Another patch may be needed to unify > the meaning of the ierrors counter. >=20 > Fixes: 5e50ad1c1b63 ("ixgbe: add specific stats") >=20 > Signed-off-by: Robin Jarry There is work to be done to allow easier distinction between drops due to the host, and errors due to bad packets. Until that work is done, write the dropped packet count to imissed, so: Acked-by: Harry van Haaren