From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id C5DC28DAF for ; Wed, 20 Jan 2016 16:59:28 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP; 20 Jan 2016 07:59:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,321,1449561600"; d="scan'208";a="731136900" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga003.jf.intel.com with ESMTP; 20 Jan 2016 07:59:22 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.97]) by IRSMSX101.ger.corp.intel.com ([169.254.1.113]) with mapi id 14.03.0248.002; Wed, 20 Jan 2016 15:58:01 +0000 From: "Van Haaren, Harry" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] ethdev: expose link status and speed using xstats Thread-Index: AQHRU47TEduIS8hXi0q1HWXGxsejKZ8EeGuAgAAATPCAAAekAIAAAskAgAAAo1A= Date: Wed, 20 Jan 2016 15:58:00 +0000 Message-ID: References: <1453300086-3756-1-git-send-email-harry.van.haaren@intel.com> <3240763.FVKPEEMrPZ@xps13> In-Reply-To: <3240763.FVKPEEMrPZ@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTZkYWE3NDItOWIyYS00MTY2LWI5YTUtNTYyOGE3NjUyMTJhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS40LjEwLjE5IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjdYd1VNVjdLOEp3aWhacEUrditUM25keXFRd2JyeTl1R0h0eExGeXB3RVE9In0= x-ctpclassification: CTP_PUBLIC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ethdev: expose link status and speed using xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2016 15:59:29 -0000 > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > 2016-01-20 10:03, Kyle Larose: > > We already have the rte_eth_link_get function. Why not let users > > continue to use that? It's well defined, it is simple, and it is > > consistent. >=20 > +1 Ok, no problem. I'll mark the link-status patch rejected in Patchwork. I've just sent the Keepalive patchset, patch #3 is of interest regarding th= is discussion: http://dpdk.org/dev/patchwork/patch/10003/ It adds a function to the API for collecting xstats, meaning it doesn't pol= lute the rte_eth_xstats_get() output. I'm interested to hear the communitie= s view of this approach. Regards, -Harry