From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A1CEE95C8 for ; Tue, 2 Feb 2016 12:40:11 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 02 Feb 2016 03:40:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,384,1449561600"; d="scan'208";a="645790358" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by FMSMGA003.fm.intel.com with ESMTP; 02 Feb 2016 03:40:10 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.97]) by IRSMSX107.ger.corp.intel.com ([169.254.10.159]) with mapi id 14.03.0248.002; Tue, 2 Feb 2016 11:40:08 +0000 From: "Van Haaren, Harry" To: "'David Harton (dharton)'" , Thomas Monjalon Thread-Topic: [dpdk-dev] Future Direction for rte_eth_stats_get() Thread-Index: AdFToifrMKxGpVsMS/qKv8msWpPa2wABEBgwAFcuL6AAA/u1IAACHmaQAAF2QyAAAKFzAAAAQq/QAAJljoAAACWe0AAG6SYAAfFiIAAAABXT8A== Date: Tue, 2 Feb 2016 11:40:08 +0000 Message-ID: References: <1A27633A6DA49C4A92FCD5D4312DBF536B09F7A4@IRSMSX106.ger.corp.intel.com> <1670837.tJHuUIkoht@xps13> <78791945dbf442b291adb72df8ec09f3@XCH-RCD-016.cisco.com> <3b3f956b6f7c490181b3db81b2c8d99a@XCH-RCD-016.cisco.com> In-Reply-To: <3b3f956b6f7c490181b3db81b2c8d99a@XCH-RCD-016.cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2Y5YmMxY2ItZTU3YS00N2E0LWFjYzktYzZlYjkxMGY1Yjk3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS40LjEwLjE5IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlVwZ0dBcDdZYmhBQkpsUElmNmlOalhcL2RcL0YxQTh1R0FPUFZtNFl0Wm9Taz0ifQ== x-ctpclassification: CTP_PUBLIC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] Future Direction for rte_eth_stats_get() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2016 11:40:12 -0000 +John, > From: David Harton=20 > Subject: RE: [dpdk-dev] Future Direction for rte_eth_stats_get() >=20 > Hi folks, >=20 > I didn't see any follow up to this response. I think you may have missed one: http://dpdk.org/ml/archives/dev/2016-January/032211.html > > However, if modifying that API is not desired then I'd > really like to have some feedback about extending the current xstats mode= l. API / ABI modification/breakage is something that will need to be considered in any discussions. The 2.3 (or 16.04) V1 patch deadline has passed, so any output from this=20 discussion will be leading to the 16.07 release. > Again, it is desired not to have to copy and/or parse strings for scalabi= lity reasons but > still maintain the "ABI flexibility" for which the xstats model was geare= d towards. Agreed. From: David Harton > enum rte_eth_stat_e { > /* accurate desc #1 */ > RTE_ETH_STAT_1, > /* accurate desc #2 */ > RTE_ETH_STAT_2, > ... > } For this enum, do you see each stat for every PMD entered here? RX_GOOD_PACKETS, What about RX and TX, is it listed twice? RX_GOOD_PACKETS, TX_GOOD_PACKETS, In a case where a VF has RX_GOOD_PACKETS, does it get its "own" set? RX_GOOD_PACKETS, TX_GOOD_PACKETS, VF_RX_GOOD_PACKETS, VF_TX_GOOD_PACKETS, I'm looking at the enum thinking it will grow out of control. Have you thought about adding metadata for RX / TX, PF / VF? If metadata info is added, it would make retrieving a set of statistics based on a certain mask much easier. Do you think this may be of use? -Harry=20