From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C1A392965 for ; Wed, 6 Apr 2016 16:32:57 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 06 Apr 2016 07:32:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,447,1455004800"; d="scan'208";a="681782284" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by FMSMGA003.fm.intel.com with ESMTP; 06 Apr 2016 07:32:55 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.19]) by irsmsx110.ger.corp.intel.com ([169.254.15.10]) with mapi id 14.03.0248.002; Wed, 6 Apr 2016 15:32:55 +0100 From: "Van Haaren, Harry" To: Rasesh Mody , "thomas.monjalon@6wind.com" CC: "dev@dpdk.org" , "ameen.rahman@qlogic.com" , "harish.patil@qlogic.com" Thread-Topic: [dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get Thread-Index: AQHRj5ybBN0biTsdlEitoop0OKBm8J99AWSw Date: Wed, 6 Apr 2016 14:32:54 +0000 Message-ID: References: <1459903028-3329-1-git-send-email-rasesh.mody@qlogic.com> <1459903028-3329-3-git-send-email-rasesh.mody@qlogic.com> In-Reply-To: <1459903028-3329-3-git-send-email-rasesh.mody@qlogic.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzJjOGIzZGUtYTQ1ZC00M2Y4LWE3NTctNWQ1NzAzNjU0NzQ2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik9PVUFVWElCajV2eGZ3bnoraVZSSEtcL1JSbzZhWldMRklxVllLM0NPaXU4PSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2016 14:32:58 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rasesh Mody > Subject: [dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get Hi Rasesh, > + snprintf(xstats[num].name, sizeof(xstats[num].name), "brb_drops"); I don't understand what a "brb" drop is. > + snprintf(xstats[num].name, sizeof(xstats[num].name), "tx_pfc"); Similarly here, and with some other of the xstats strings, it doesn't become clear to me what exactly the value represents. "mac_filter_discard" is descriptive and readable, but the next stat has "mf_tag_discard" - these small inconsistencies make it much harder (impossible?) to scrap the xstats strings and retrieve useful metadata. I'll suggest leaving the xstats implementation part of this patch until the next release, and we can align on the names of the stats. -Harry