From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <harry.van.haaren@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 5BA26108F
 for <dev@dpdk.org>; Tue, 17 Jan 2017 11:00:03 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga102.fm.intel.com with ESMTP; 17 Jan 2017 02:00:03 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,243,1477983600"; d="scan'208";a="1083928034"
Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3])
 by orsmga001.jf.intel.com with ESMTP; 17 Jan 2017 02:00:00 -0800
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.230]) by
 IRSMSX108.ger.corp.intel.com ([169.254.11.173]) with mapi id 14.03.0248.002;
 Tue, 17 Jan 2017 10:00:00 +0000
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Richardson, Bruce"
 <bruce.richardson@intel.com>
Thread-Topic: [PATCH 01/15] eventdev: remove unneeded dependencies
Thread-Index: AQHScA8B1ZTF6ptykE2JsnUoCDM6YKE8Y04AgAAL67A=
Date: Tue, 17 Jan 2017 09:59:59 +0000
Message-ID: <E923DB57A917B54B9182A2E928D00FA6129E3A84@IRSMSX102.ger.corp.intel.com>
References: <1484581255-148720-1-git-send-email-harry.van.haaren@intel.com>
 <1484581255-148720-2-git-send-email-harry.van.haaren@intel.com>
 <20170117091139.GA17275@localhost.localdomain>
In-Reply-To: <20170117091139.GA17275@localhost.localdomain>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDg3NGVhNDYtYjBkYy00NjRiLWE3ZWItNjNhOGIyMDUwMGMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IktBZzRpR0lJcEVNY1wvUU91cVwvT2wwME9lOEUzb2QxU045YWlQVHJTUmhVWT0ifQ==
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 01/15] eventdev: remove unneeded dependencies
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jan 2017 10:00:04 -0000

> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> >
> >  #include <rte_common.h>
> > -#include <rte_pci.h>
> > -#include <rte_mbuf.h>
> > +#include <rte_memory.h>
> > +
> > +struct rte_mbuf; /* we just use mbuf pointers; no need to include rte_=
mbuf.h */
>=20
> This "struct rte_mbuf" reference is not present in dpdk-next-eventdev tre=
e.
> Are you planning to rebase to dpdk-next-eventdev?


The idea was to remove the include of the header file, as we never derefere=
nce the mbuf pointer, and hence we shouldn't include a header we don't requ=
ire.

The struct rte_mbuf here is just a forward declaration for the actual rte_m=
buf. This allows the rte_event to contain a struct rte_mbuf* without the co=
mpiler complaining that it doesn't understand the type.


The current patches apply to dpdk-next-eventdev HEAD, I don't think I under=
stand what you're asking about rebasing.