From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 2F3F12BAA for ; Fri, 10 Feb 2017 11:31:34 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP; 10 Feb 2017 02:31:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,140,1484035200"; d="scan'208";a="932320288" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga003.jf.intel.com with ESMTP; 10 Feb 2017 02:31:31 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.230]) by IRSMSX106.ger.corp.intel.com ([169.254.8.197]) with mapi id 14.03.0248.002; Fri, 10 Feb 2017 10:31:31 +0000 From: "Van Haaren, Harry" To: Nipun Gupta , "dev@dpdk.org" CC: "hemant.agrawal@nxp.com" , "jerin.jacob@caviumnetworks.com" , "Richardson, Bruce" , "Eads, Gage" Thread-Topic: [PATCH v2] eventdev: amend comments for events limit and threshold Thread-Index: AQHSg4LB4GqW5qX0qESMOUNM+pKAqaFiAqlw Date: Fri, 10 Feb 2017 10:31:30 +0000 Message-ID: References: <1486739104-10953-1-git-send-email-nipun.gupta@nxp.com> <1486741801-18258-1-git-send-email-nipun.gupta@nxp.com> In-Reply-To: <1486741801-18258-1-git-send-email-nipun.gupta@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTgzMTIwYWQtNDI5NS00MjQwLTkwZDUtODc3MmY4OWIxYWJhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlBpdlhVc0VVRldqY1E1T0c4TGV6U2hXQUwyTUp5TXJ0QWlPMnJSV0F3WXM9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] eventdev: amend comments for events limit and threshold X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2017 10:31:34 -0000 > From: Nipun Gupta [mailto:nipun.gupta@nxp.com] > Sent: Friday, February 10, 2017 3:50 PM > To: dev@dpdk.org > Cc: hemant.agrawal@nxp.com; jerin.jacob@caviumnetworks.com; Richardson, B= ruce > ; Eads, Gage ; Van Haare= n, Harry > ; Nipun Gupta > Subject: [PATCH v2] eventdev: amend comments for events limit and thresho= ld >=20 > Updated the comments on 'nb_events_limit' of 'struct rte_event_dev_config= ' > and 'new_event_threshold' of 'struct rte_event_port_conf' for open system > configuration. >=20 > Signed-off-by: Nipun Gupta > --- > Changes for v2: > - Fix errors reported by check-git-log.sh >=20 > lib/librte_eventdev/rte_eventdev.h | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) >=20 > diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte= _eventdev.h > index c2f9310..171e52e 100644 > --- a/lib/librte_eventdev/rte_eventdev.h > +++ b/lib/librte_eventdev/rte_eventdev.h > @@ -404,11 +404,12 @@ struct rte_event_dev_config { > * @see RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT > */ > int32_t nb_events_limit; > - /**< Applies to *closed system* event dev only. This field indicates a > - * limit to ethdev-like devices to limit the number of events injected > - * into the system to not overwhelm core-to-core events. > + /**< In a *closed system* this field indicates a limit to ethdev-like > + * devices to limit the number of events injected into the system to > + * not overwhelm core-to-core events. > * This value cannot exceed the *max_num_events* which previously > - * provided in rte_event_dev_info_get() > + * provided in rte_event_dev_info_get(). > + * This should be set to '-1' for *open system*. I don't think we should mention ethdev explicitly here - it applies to any port that is attempting to enqueue work into a closed-system eventdev. What do you think of the following wording? (Suggestion only, feel free to re-word if required). /**< In a closed system this field is the limit on the maximum number of ev= ents that can be inflight in the eventdev at a given time. The limit is req= uired to ensure that the finite space in a closed system is not overwhelmed.= The value cannot exceed the *max_num_events* as provided by rte_event_dev_= info_get(). This value should be set to -1 for open systems. */ > */ > uint8_t nb_event_queues; > /**< Number of event queues to configure on this device. > @@ -633,7 +634,8 @@ struct rte_event_port_conf { > * can have a lower threshold so as not to overwhelm the device, > * while ports used for worker pools can have a higher threshold. > * This value cannot exceed the *nb_events_limit* > - * which previously supplied to rte_event_dev_configure() > + * which previously supplied to rte_event_dev_configure(). > + * This should be set to '-1' for *open system*. > */ Minor grammer issue (that was previously there too, but worth fixing anyway= ), there is a _was_ missing from the sentence: + which was previously supplied to rte_event_dev_configure().