From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id EF4CD2B93 for ; Fri, 3 Mar 2017 15:23:57 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Mar 2017 06:23:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,237,1484035200"; d="scan'208";a="71245173" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga005.jf.intel.com with ESMTP; 03 Mar 2017 06:23:55 -0800 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX151.ger.corp.intel.com (163.33.192.59) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 3 Mar 2017 14:23:55 +0000 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.230]) by irsmsx112.ger.corp.intel.com ([169.254.1.175]) with mapi id 14.03.0248.002; Fri, 3 Mar 2017 14:23:54 +0000 From: "Van Haaren, Harry" To: "Tahhan, Maryam" , "dev@dpdk.org" CC: "Korynkevych, RomanX" Thread-Topic: [dpdk-dev] [PATCH v3] proc-info: added collectd-format and host-id options. Thread-Index: AQHSkqjs9ifVWh/wlku8GDPBMRKNgaGDH6EAgAAJnCA= Date: Fri, 3 Mar 2017 14:23:54 +0000 Message-ID: References: <1488204982-32291-1-git-send-email-romanx.korynkevych@intel.com> <1488385639-31471-1-git-send-email-romanx.korynkevych@intel.com> <1A27633A6DA49C4A92FCD5D4312DBF536B50CA44@IRSMSX106.ger.corp.intel.com> In-Reply-To: <1A27633A6DA49C4A92FCD5D4312DBF536B50CA44@IRSMSX106.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGE1YzUyZDEtNmZmYS00NGNkLTk3ZjItZDAyYjdiYmRiNGU3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiJLbkxmeUx1SEgzOHpSclROeExIT0tra0RMUlwvQnRYXC82VGdXZnZGUStpc1U9In0= x-ctpclassification: CTP_PUBLIC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] proc-info: added collectd-format and host-id options. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 14:23:58 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tahhan, Maryam > Sent: Friday, March 3, 2017 1:32 PM > To: Korynkevych, RomanX ; dev@dpdk.org > Cc: Korynkevych, RomanX > Subject: Re: [dpdk-dev] [PATCH v3] proc-info: added collectd-format and h= ost-id options. >=20 > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Roman Korynkevych > > Sent: Wednesday, March 1, 2017 4:27 PM > > To: dev@dpdk.org > > Cc: Korynkevych, RomanX > > Subject: [dpdk-dev] [PATCH v3] proc-info: added collectd-format and hos= t-id > > options. > > > > Extended proc-info application to send DPDK port statistics to STDOUT i= n the > > format expected by collectd exec plugin. Added HOST ID option to identi= fy the > > host DPDK process is running on when multiple instance of DPDK are runn= ing in > > parallel. This is needed for the barometer project in OPNFV. > > > > Signed-off-by: Roman Korynkevych >=20 > Reviewed-by: Maryam Tahhan Hi Roman, Just a few pointers on DPDK patch rework / review practice; - CC people involved in discussion / review of previous versions - If somebody review / acks your patch, with a request for simple-error rew= ork, it is allowed to include their Reviewed-by / acked by. Note the changes m= ust be minor, or keeping the Review/Ack suggested by the person[1] - When updating a patch, it is good practice to summarize the changes made under the --- line, so it is easier for reviewers to see changes made. That said, no problem, just something to keep in mind for next patches :) Nice work, Acked-by: Harry van Haaren [1] http://dpdk.org/dev/patchwork/patch/20898/