From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 9DDD72C48 for ; Fri, 10 Mar 2017 16:24:56 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Mar 2017 07:24:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,141,1486454400"; d="scan'208";a="833179345" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by FMSMGA003.fm.intel.com with ESMTP; 10 Mar 2017 07:24:54 -0800 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 10 Mar 2017 15:24:53 +0000 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.230]) by IRSMSX156.ger.corp.intel.com ([169.254.3.104]) with mapi id 14.03.0248.002; Fri, 10 Mar 2017 15:24:53 +0000 From: "Van Haaren, Harry" To: Jerin Jacob CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 01/17] eventdev: fix API docs and test for timeout ticks Thread-Index: AQHSlmVGLeLUysUxIUCN7KzqdNxXJqGONrYQ Date: Fri, 10 Mar 2017 15:24:52 +0000 Message-ID: References: <1485879273-86228-1-git-send-email-harry.van.haaren@intel.com> <1487343252-16092-1-git-send-email-harry.van.haaren@intel.com> <1487343252-16092-2-git-send-email-harry.van.haaren@intel.com> <20170306103356.GA28766@localhost.localdomain> In-Reply-To: <20170306103356.GA28766@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTNkNzk4Y2UtNGJlYy00MmE3LWExYTQtNDAxYjc3ZTllYzk4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IklGS3lxYnQ5SnJ5cWlIZ0w1MFNnb2hhNjZzbTZ4d0lDSWswWFZaMFwvWUdjPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 01/17] eventdev: fix API docs and test for timeout ticks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 15:24:57 -0000 > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Monday, March 6, 2017 10:34 AM > To: Van Haaren, Harry > Subject: Re: [PATCH v3 01/17] eventdev: fix API docs and test for timeout= ticks > > ret =3D rte_event_dequeue_timeout_ticks(TEST_DEV_ID, 100, &timeout_ti= cks); > > - TEST_ASSERT_SUCCESS(ret, "Fail to get timeout_ticks"); > > + /* -ENOTSUP is a valid return if timeout is not supported by device = */ > > + if (ret !=3D -ENOTSUP) > > + TEST_ASSERT_SUCCESS(ret, "Fail to get timeout_ticks"); >=20 > Header file change looks good. IMO, In the test case, We can introduce > TEST_UNSUPPORTED in addition to TEST_SUCCESS and TEST_FAILED to reflect > the actual status. I guess it will useful for future tests as well. Adding TEST_UNSUPPORTED requires a larger changeset than software eventdev = should make to the test infrastructure; my preference is to use the error check so= lution as above for v4 patchset. Rework of testing infrastructure should be done on mainline dpdk if deemed = required, and enable on Eventdev branch after a rebase.