From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D053F1075 for ; Mon, 13 Mar 2017 12:01:15 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2017 04:01:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,158,1486454400"; d="scan'208";a="66873179" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga004.jf.intel.com with ESMTP; 13 Mar 2017 04:01:14 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 13 Mar 2017 11:01:13 +0000 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.230]) by irsmsx111.ger.corp.intel.com ([169.254.2.109]) with mapi id 14.03.0248.002; Mon, 13 Mar 2017 11:01:13 +0000 From: "Van Haaren, Harry" To: "Hunt, David" , "Richardson, Bruce" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v9 09/18] lib: add symbol versioning to distributor Thread-Index: AQHSlpR6PDf2fikSG0m14NmeR+7wPKGOR9wAgARUMACAAAh/oA== Date: Mon, 13 Mar 2017 11:01:13 +0000 Message-ID: References: <1488354455-142764-2-git-send-email-david.hunt@intel.com> <1488791433-186137-1-git-send-email-david.hunt@intel.com> <1488791433-186137-10-git-send-email-david.hunt@intel.com> <20170310162228.GB339712@bricha3-MOBL3.ger.corp.intel.com> <73b1521e-6517-d74c-8113-86a634f1a0ce@intel.com> In-Reply-To: <73b1521e-6517-d74c-8113-86a634f1a0ce@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzAyNzE4MDUtMTc5Zi00NmU2LTk2ZWUtMDUwMmVjODE2ZGZmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlprTHlWMHlISHlzamF6bjFLalpCTkd3S0NPdXBhXC9tWjUyQjljbWpjRXpZPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v9 09/18] lib: add symbol versioning to distributor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Mar 2017 11:01:16 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hunt, David > Subject: Re: [dpdk-dev] [PATCH v9 09/18] lib: add symbol versioning to di= stributor >=20 > On 10/3/2017 4:22 PM, Bruce Richardson wrote: > > On Mon, Mar 06, 2017 at 09:10:24AM +0000, David Hunt wrote: > >> Also bumped up the ABI version number in the Makefile > >> > >> Signed-off-by: David Hunt > >> --- > >> lib/librte_distributor/Makefile | 2 +- > >> lib/librte_distributor/rte_distributor.c | 57 +++++++++++-= -- > >> lib/librte_distributor/rte_distributor_v1705.h | 89 ++++++++++++= ++++++++++ > > A file named rte_distributor_v1705.h was added in patch 4, then deleted > > in patch 7, and now added again here. Seems a lot of churn. > > > > /Bruce > > >=20 > The first introduction of this file is what will become the public > header. For successful compilation, > this cannot be called rte_distributor.h until the symbol versioning > patch, at which stage I will > rename the file, and introduce the symbol versioned header at the same > time. In the next patch > I'll rename this version of the files as rte_distributor_public.h to > make this clearer. Suggestion to use rte_distributor_next.h instead of public? Public doesn't indicate if its old or new, while next would make that clear= er IMO :)