From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 86E4E5424 for ; Wed, 29 Mar 2017 12:58:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490785085; x=1522321085; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jKjsSp+nNhmL/CLiRlYhoA9vYcU6t+ctVuMb4LEwWZQ=; b=X8FB4/91WxIJjeFjmHL5I367AlPeE4FvIcdGrd3qe83A0KdOuzaZVp2Q FFb6mN8hzQN6aRIn3StglIjfbJ6rJA==; Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2017 03:58:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,240,1486454400"; d="scan'208";a="839622433" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by FMSMGA003.fm.intel.com with ESMTP; 29 Mar 2017 03:58:02 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.153]) by IRSMSX103.ger.corp.intel.com ([169.254.3.241]) with mapi id 14.03.0319.002; Wed, 29 Mar 2017 11:58:02 +0100 From: "Van Haaren, Harry" To: Jerin Jacob CC: "dev@dpdk.org" , "Richardson, Bruce" Thread-Topic: [PATCH v5 08/20] event/sw: add support for linking queues to ports Thread-Index: AQHSpL8pE/UYcs5/40qiwc1qHZdk1qGofgYAgAMtN9A= Date: Wed, 29 Mar 2017 10:58:01 +0000 Message-ID: References: <489175012-101439-1-git-send-email-harry.van.haaren@intel.com> <1490374395-149320-1-git-send-email-harry.van.haaren@intel.com> <1490374395-149320-9-git-send-email-harry.van.haaren@intel.com> <20170327112028.vrk5dwuvp5kvuqz7@localhost.localdomain> In-Reply-To: <20170327112028.vrk5dwuvp5kvuqz7@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWQ3Y2JiMmUtYWRkYi00NjI5LThjZjQtZDUzOGIwMmY1MjE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im50SVU2THZNa2NyS0VMeFU2QSt1VDUrdUYzeEpVMGMyME1jWlhkN2VjR3c9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 08/20] event/sw: add support for linking queues to ports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 10:58:05 -0000 > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Monday, March 27, 2017 12:21 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Richardson, Bruce > Subject: Re: [PATCH v5 08/20] event/sw: add support for linking queues to= ports > > + break; > > + > > + if (q->type =3D=3D SW_SCHED_TYPE_DIRECT) { > > + /* check directed qids only map to one port */ > > + if (p->num_qids_mapped > 0) { > > + rte_errno =3D -EDQUOT; > > + break; > > + } > > + /* check port only takes a directed flow */ > > + if (num > 1) { > > + rte_errno =3D -EDQUOT; > > + break; > > + } > > + > > + p->is_directed =3D 1; > > + p->num_qids_mapped =3D 1; > > + } else if (q->type =3D=3D RTE_SCHED_TYPE_ORDERED) { >=20 > Will this "else if" have similar issue shared in > http://dpdk.org/ml/archives/dev/2017-March/061497.html This particular issue has been resolved by fixing in patch 06/20. The other= issues you've raised on this patch are fixed, Thanks again for your feedba= ck - the bug in 06/20 was a great catch!