From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <harry.van.haaren@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 9203DFC01
 for <dev@dpdk.org>; Thu, 30 Mar 2017 10:50:02 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga105.jf.intel.com with ESMTP; 30 Mar 2017 01:50:01 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,245,1486454400"; d="scan'208";a="241960929"
Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23])
 by fmsmga004.fm.intel.com with ESMTP; 30 Mar 2017 01:50:00 -0700
Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by
 IRSMSX109.ger.corp.intel.com (163.33.3.23) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Thu, 30 Mar 2017 09:49:59 +0100
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.153]) by
 irsmsx111.ger.corp.intel.com ([169.254.2.58]) with mapi id 14.03.0319.002;
 Thu, 30 Mar 2017 09:49:59 +0100
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Richardson, Bruce"
 <bruce.richardson@intel.com>
Thread-Topic: [PATCH v6 12/21] event/sw: add start stop and close functions
Thread-Index: AQHSqOPnNGJlHM3XdUW3jnK4qkox26Gs+4uAgAAXbeA=
Date: Thu, 30 Mar 2017 08:49:58 +0000
Message-ID: <E923DB57A917B54B9182A2E928D00FA612A23A7D@IRSMSX102.ger.corp.intel.com>
References: <1490374395-149320-1-git-send-email-harry.van.haaren@intel.com>
 <1490829963-106807-1-git-send-email-harry.van.haaren@intel.com>
 <1490829963-106807-13-git-send-email-harry.van.haaren@intel.com>
 <20170330082426.p7vvghxkyfct5gis@localhost.localdomain>
In-Reply-To: <20170330082426.p7vvghxkyfct5gis@localhost.localdomain>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODk2YzJhYTEtOTNmNS00MWRkLWJmOTctY2E3MzM2NmFhMTA2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImxvWitnU2ozeHRsbURMMXhNakRUeWxVK1wvNG1lUGtHNVlzVk92K09RRGVzPSJ9
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v6 12/21] event/sw: add start stop and close
	functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Mar 2017 08:50:03 -0000

> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Thursday, March 30, 2017 9:24 AM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>
> Subject: Re: [PATCH v6 12/21] event/sw: add start stop and close function=
s

<snip>

> >  static int
> > +sw_start(struct rte_eventdev *dev)
> > +{
> > +	unsigned int i, j;
> > +	struct sw_evdev *sw =3D sw_pmd_priv(dev);
> > +	/* check all ports are set up */
> > +	for (i =3D 0; i < sw->port_count; i++)
> > +		if (sw->ports[i].rx_worker_ring =3D=3D NULL) {
> > +			SW_LOG_ERR("%s %d: port %d not configured\n",
> > +			       __func__, __LINE__, i);
>=20
> Remove __func__ and __LINE_ as SW_LOG_ERR macro has it already.
> Check the same issue in other places.

Good one, done and checked for all patches, will be fixed in v7.