From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 1F417316B for ; Thu, 30 Mar 2017 19:24:30 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP; 30 Mar 2017 10:24:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,247,1486454400"; d="scan'208";a="1129000628" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga001.fm.intel.com with ESMTP; 30 Mar 2017 10:24:21 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.153]) by IRSMSX154.ger.corp.intel.com ([169.254.12.233]) with mapi id 14.03.0319.002; Thu, 30 Mar 2017 18:24:20 +0100 From: "Van Haaren, Harry" To: Jerin Jacob CC: "dev@dpdk.org" Thread-Topic: [PATCH v6 01/21] eventdev: improve API docs for start function Thread-Index: AQHSqOPiyRqysj12eUC8lHso4CrNiaGtjtCAgAAS7VA= Date: Thu, 30 Mar 2017 17:24:20 +0000 Message-ID: References: <1490374395-149320-1-git-send-email-harry.van.haaren@intel.com> <1490829963-106807-1-git-send-email-harry.van.haaren@intel.com> <1490829963-106807-2-git-send-email-harry.van.haaren@intel.com> <20170330171132.kbwpsnukw5sr5frg@localhost.localdomain> In-Reply-To: <20170330171132.kbwpsnukw5sr5frg@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWJiNzc3YzMtZTc5YS00MWEzLWJlMTgtODcwOTZlMjk2ODFlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IldoM2ExYTdUV0xSanJcLzBzcTBkSERiaVJjVElFTEVDSUh2cHhkVGJZajBvPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 01/21] eventdev: improve API docs for start function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 17:24:31 -0000 Sure, will send an updated patch tomorrow, thanks! > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Thursday, March 30, 2017 6:12 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org > Subject: Re: [PATCH v6 01/21] eventdev: improve API docs for start functi= on >=20 > On Thu, Mar 30, 2017 at 12:25:43AM +0100, Harry van Haaren wrote: > > This commit documents two error return values for the > > rte_event_dev_start() function. > > > > -EINVAL indicates not all ports are configured >=20 > -EINVAL returns in case of an invalid dev_id. How about -ESTALE or > something like that? >=20 > > -EDEADLK indicates that not all queues are linked to ports. If an > > application enqueues to such a queue it can lead to deadlock >=20 > IMO, Deadlock is an implementation detail all the PMD may not result in > deadlock. How about -ENOLINK ? >=20 > IMO, If you want to enforce this rule then the detection and > check has to be be in common code to avoid all PMD duplicating the same > code. >=20 > > > > Signed-off-by: Harry van Haaren > > --- > > lib/librte_eventdev/rte_eventdev.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/r= te_eventdev.h > > index 9971937..dc8dacb 100644 > > --- a/lib/librte_eventdev/rte_eventdev.h > > +++ b/lib/librte_eventdev/rte_eventdev.h > > @@ -757,7 +757,8 @@ rte_event_port_count(uint8_t dev_id); > > * Event device identifier > > * @return > > * - 0: Success, device started. > > - * - <0: Error code of the driver device start function. > > + * - -EINVAL : Not all ports of the device are configured > > + * - -EDEADLK: Not all queues are linked, which could lead to deadlo= ck. > > */ > > int > > rte_event_dev_start(uint8_t dev_id); > > -- > > 2.7.4 > >