From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <harry.van.haaren@intel.com> Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7E7842BB1 for <dev@dpdk.org>; Thu, 13 Apr 2017 18:23:39 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Apr 2017 09:23:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,195,1488873600"; d="scan'208";a="73701721" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga002.jf.intel.com with ESMTP; 13 Apr 2017 09:23:37 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.153]) by IRSMSX106.ger.corp.intel.com ([169.254.8.202]) with mapi id 14.03.0319.002; Thu, 13 Apr 2017 17:23:36 +0100 From: "Van Haaren, Harry" <harry.van.haaren@intel.com> To: "Kozak, KubaX" <kubax.kozak@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "Jain, Deepak K" <deepak.k.jain@intel.com>, "Piasecki, JacekX" <jacekx.piasecki@intel.com>, "Kulasek, TomaszX" <tomaszx.kulasek@intel.com> Thread-Topic: [PATCH v6 1/5] ethdev: new xstats API add retrieving by ID Thread-Index: AQHStFZNmnwZ0eTOuU6K9l94hltRUKHDe2qw Date: Thu, 13 Apr 2017 16:23:35 +0000 Message-ID: <E923DB57A917B54B9182A2E928D00FA612A2CFB2@IRSMSX102.ger.corp.intel.com> References: <1491928644-10383-2-git-send-email-michalx.k.jastrzebski@intel.com> <1492095568-20993-1-git-send-email-kubax.kozak@intel.com> <1492095568-20993-2-git-send-email-kubax.kozak@intel.com> In-Reply-To: <1492095568-20993-2-git-send-email-kubax.kozak@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWY0MDY0ZmMtZDU3OC00MzJjLWEzZDctMzAzMGU2Mzg5MDA0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiI1ZDQ0T2lzTE8waGNWMVRkaXlpQWpcL1VaZ3NoclREaTJLS3JKa045elZYcz0ifQ== x-ctpclassification: CTP_PUBLIC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 1/5] ethdev: new xstats API add retrieving by ID X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 13 Apr 2017 16:23:40 -0000 > From: Kozak, KubaX > Sent: Thursday, April 13, 2017 3:59 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Jain, Deepak K <deepa= k.k.jain@intel.com>; > Piasecki, JacekX <jacekx.piasecki@intel.com>; Kozak, KubaX <kubax.kozak@i= ntel.com>; Kulasek, > TomaszX <tomaszx.kulasek@intel.com> > Subject: [PATCH v6 1/5] ethdev: new xstats API add retrieving by ID >=20 > From: Jacek Piasecki <jacekx.piasecki@intel.com> >=20 > Extended xstats API in ethdev library to allow grouping of stats > logically so they can be retrieved per logical grouping managed > by the application. > Changed existing functions rte_eth_xstats_get_names and > rte_eth_xstats_get to use a new list of arguments: array of ids > and array of values. ABI versioning mechanism was used to > support backward compatibility. > Introduced two new functions rte_eth_xstats_get_all and > rte_eth_xstats_get_names_all which keeps functionality of the > previous ones (respectively rte_eth_xstats_get and > rte_eth_xstats_get_names) but use new API inside. >=20 > test-pmd: add support for new xstats API retrieving by id in > testpmd application: xstats_get() and > xstats_get_names() call with modified parameters. >=20 > doc: add description for modified xstats API > Documentation change for modified extended statistics API functions. > The old API only allows retrieval of *all* of the NIC statistics > at once. Given this requires a MMIO read PCI transaction per statistic > it is an inefficient way of retrieving just a few key statistics. > Often a monitoring agent only has an interest in a few key statistics, > and the old API forces wasting CPU time and PCIe bandwidth in retrieving > *all* statistics; even those that the application didn't explicitly > show an interest in. > The new, more flexible API allow retrieval of statistics per ID. > If a PMD wishes, it can be implemented to read just the required > NIC registers. As a result, the monitoring application no longer wastes > PCIe bandwidth and CPU time. >=20 > Signed-off-by: Jacek Piasecki <jacekx.piasecki@intel.com> > Signed-off-by: Kuba Kozak <kubax.kozak@intel.com> > Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>