From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 21E9F3772 for ; Fri, 30 Jun 2017 10:40:09 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jun 2017 01:40:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,285,1496127600"; d="scan'208";a="119301221" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga005.jf.intel.com with ESMTP; 30 Jun 2017 01:40:07 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX108.ger.corp.intel.com (163.33.3.3) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 30 Jun 2017 09:40:06 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.211]) by irsmsx155.ger.corp.intel.com ([169.254.14.182]) with mapi id 14.03.0319.002; Fri, 30 Jun 2017 09:40:06 +0100 From: "Van Haaren, Harry" To: Jerin Jacob , "dev@dpdk.org" CC: "Richardson, Bruce" , "hemant.agrawal@nxp.com" , "Eads, Gage" , "nipun.gupta@nxp.com" , "Vangati, Narender" , "Rao, Nikhil" Thread-Topic: [dpdk-dev] [PATCH 2/5] eventdev: introduce specialized enqueue new op variant Thread-Index: AQHS8OLypJfWXAwPGkKD89BxmzmfsaI9FBhQ Date: Fri, 30 Jun 2017 08:40:06 +0000 Message-ID: References: <20170629141956.23132-1-jerin.jacob@caviumnetworks.com> <20170629141956.23132-2-jerin.jacob@caviumnetworks.com> In-Reply-To: <20170629141956.23132-2-jerin.jacob@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTg5MDdmNjItOGNlMy00YmM4LTgxMDItZDFhNGI4MTUxZTQyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Imp4OEt4OXFDOHJvUEphK0tERk9wQSt1cEpKS1B0YUxaeXRFTWhVQU1MXC9FPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/5] eventdev: introduce specialized enqueue new op variant X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2017 08:40:11 -0000 > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Thursday, June 29, 2017 3:20 PM > To: dev@dpdk.org > diff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeont= x/ssovf_evdev.c > index 8dc7b2ef8..0d0c6a186 100644 > --- a/drivers/event/octeontx/ssovf_evdev.c > +++ b/drivers/event/octeontx/ssovf_evdev.c > @@ -158,6 +158,7 @@ ssovf_fastpath_fns_set(struct rte_eventdev *dev) > dev->schedule =3D NULL; > dev->enqueue =3D ssows_enq; > dev->enqueue_burst =3D ssows_enq_burst; > + dev->enqueue_new_burst =3D ssows_enq_burst; > dev->dequeue =3D ssows_deq; > dev->dequeue_burst =3D ssows_deq_burst; >=20 > diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c > index fe2a61e2f..951ad1b33 100644 > --- a/drivers/event/sw/sw_evdev.c > +++ b/drivers/event/sw/sw_evdev.c > @@ -796,6 +796,7 @@ sw_probe(struct rte_vdev_device *vdev) > dev->dev_ops =3D &evdev_sw_ops; > dev->enqueue =3D sw_event_enqueue; > dev->enqueue_burst =3D sw_event_enqueue_burst; > + dev->enqueue_new_burst =3D sw_event_enqueue_burst; > dev->dequeue =3D sw_event_dequeue; > dev->dequeue_burst =3D sw_event_dequeue_burst; > dev->schedule =3D sw_event_schedule; I think it is possible to do this pointer-setting of new_burst() in eventde= v.c, instead of adding the new_burst() to each PMD individually? During rte_eventdev_configure(), if the dev->enqueue_new_burst() function i= s NULL, just point it at the ordinary one; if (!dev->enqueue_new_burst) dev->enqueue_new_burst =3D dev->enqueue_burst; This saves per-PMD changes for adding new parallel function pointers - and = avoids PMDs accidentally not being updated. With that change; Acked-by: Harry van Haaren